You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/08/09 02:58:53 UTC
[GitHub] [guacamole-client] jmuehlner commented on a change in pull request
#435: GUACAMOLE-630: Allow parameters received via "argv" streams to be
edited within the Guacamole menu.
jmuehlner commented on a change in pull request #435: GUACAMOLE-630: Allow parameters received via "argv" streams to be edited within the Guacamole menu.
URL: https://github.com/apache/guacamole-client/pull/435#discussion_r312314322
##########
File path: guacamole/src/main/webapp/app/client/templates/client.html
##########
@@ -96,6 +96,15 @@ <h3>{{'CLIENT.SECTION_HEADER_DEVICES' | translate}}</h3>
</div>
</div>
+ <!-- Connection parameters which may be modified while the connection is open -->
+ <div class="menu-section connection-parameters" id="connection-settings" ng-show="client.protocol">
+ <guac-form namespace="getProtocolNamespace(client.protocol)"
+ content="client.forms"
+ model="menu.connectionParameters"
+ model-only="true"
+ data-disabled="true"></guac-form>
Review comment:
Why is this disabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services