You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/12 04:37:49 UTC
[GitHub] [apisix-website] navendu-pottekkat opened a new issue, #1084: [Site]: Add lightbox to display images
navendu-pottekkat opened a new issue, #1084:
URL: https://github.com/apache/apisix-website/issues/1084
### Current State
**Description of the current state/issue**:
Currently, to zoom in to an image, users have to open just the image in a new tab.
This makes it difficult to understand large diagrams.
### Desired State
**Description of the change you are proposing**:
Instead, add a lightbox feature that would open up a modal that the users can interact with when clicking an image.
Here is an example of a lightbox: https://www.lightgalleryjs.com/
### Would you like to fix this issue?
No. Please assign another contributor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1128492335
Or this one? https://github.com/brycedorn/react-intense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1128935175
> https://github.com/react-component/image This one! It looks great!
Ah! I just have a try and it's good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1129597137
> Looks good!
I will start this work as soon as possible😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] navendu-pottekkat commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1124521982
@SkyeYoung Here you go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] navendu-pottekkat commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1129594975
Looks good!
Uploading Screen Recording 2022-05-18 at 10.58.08 AM.mov…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1128489773
@navendu-pottekkat Hi, I think https://github.com/rpearce/image-zoom may be more appropriate. But it will prevent us from getting the image directly (by right clicking the mouse), do you think this will have a very big impact?
cc @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1128544417
I am looking for other dependencies that can be used. 😮💨😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1128557023
https://github.com/react-component/image This one! It looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] navendu-pottekkat commented on issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on issue #1084:
URL: https://github.com/apache/apisix-website/issues/1084#issuecomment-1128537665
> @navendu-pottekkat Hi, I think [rpearce/image-zoom](https://github.com/rpearce/image-zoom) may be more appropriate. But it will prevent us from getting the image directly (by right clicking the mouse), do you think this will have a very big impact?
>
> cc @juzhiyuan
This looks quite good. It may be a problem to not be able to right-click and save. Especially if you want to share something on a different platform.
> Or this one? [brycedorn/react-intense](https://github.com/brycedorn/react-intense)
This feels kind of bloated IMO. I think we can keep it as simple as possible.
Others, please suggest!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi closed issue #1084: [Site]: Add lightbox to display images
Posted by GitBox <gi...@apache.org>.
guoqqqi closed issue #1084: [Site]: Add lightbox to display images
URL: https://github.com/apache/apisix-website/issues/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org