You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/12/27 10:09:09 UTC

Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5640
    https://issues.apache.org/jira/browse/CLOUDSTACK-5640


Repository: cloudstack-git


Description
-------

Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
Corrected the imports in 5 test suites which failed in recent build.


Diffs
-----

  test/integration/component/test_egress_fw_rules.py 919725f 
  test/integration/component/test_haproxy.py 1c8dc63 
  test/integration/smoke/test_deploy_vm_with_userdata.py 8910b2e 
  test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py a08537e 
  test/integration/smoke/test_service_offerings.py 22273d7 

Diff: https://reviews.apache.org/r/16481/diff/


Testing
-------

Tested using command "python test_suite_name.py"


Thanks,

Gaurav Aradhye

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/#review30949
-----------------------------------------------------------


Commit cbe93be2e9a84e6f523f8514455f31f91e0345a7 in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cbe93be ]

CLOUDSTACK-5640: Correcting imports in test cases


- ASF Subversion and Git Services


On Dec. 30, 2013, 8:10 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16481/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 8:10 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5640
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
> Corrected the imports in 5 test suites which failed in recent build.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_memory_limits.py 7da85a5 
>   test/integration/component/test_security_groups.py c90ccf6 
>   test/integration/component/test_snapshots_improvement.py 190db55 
>   test/integration/component/test_vmware_drs.py 8eeb2c3 
> 
> Diff: https://reviews.apache.org/r/16481/diff/
> 
> 
> Testing
> -------
> 
> Tested using command "python test_suite_name.py"
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/#review30950
-----------------------------------------------------------


Commit 5882123f19b27baab579ee4ef6de752614208a85 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5882123 ]

CLOUDSTACK-5640: Correcting imports in test cases

Conflicts:
	test/integration/component/test_security_groups.py


- ASF Subversion and Git Services


On Dec. 30, 2013, 8:10 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16481/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 8:10 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5640
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
> Corrected the imports in 5 test suites which failed in recent build.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_memory_limits.py 7da85a5 
>   test/integration/component/test_security_groups.py c90ccf6 
>   test/integration/component/test_snapshots_improvement.py 190db55 
>   test/integration/component/test_vmware_drs.py 8eeb2c3 
> 
> Diff: https://reviews.apache.org/r/16481/diff/
> 
> 
> Testing
> -------
> 
> Tested using command "python test_suite_name.py"
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/#review30948
-----------------------------------------------------------

Ship it!


Committed to 4.3 and master.

- Girish Shilamkar


On Dec. 30, 2013, 8:10 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16481/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 8:10 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5640
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
> Corrected the imports in 5 test suites which failed in recent build.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_memory_limits.py 7da85a5 
>   test/integration/component/test_security_groups.py c90ccf6 
>   test/integration/component/test_snapshots_improvement.py 190db55 
>   test/integration/component/test_vmware_drs.py 8eeb2c3 
> 
> Diff: https://reviews.apache.org/r/16481/diff/
> 
> 
> Testing
> -------
> 
> Tested using command "python test_suite_name.py"
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/
-----------------------------------------------------------

(Updated Dec. 30, 2013, 1:40 p.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
-------

Dry ran all test suites in component and smoke folders with python command. There were issues with another 3 test suites' imports.
Adding patch to correct them.


Bugs: CLOUDSTACK-5640
    https://issues.apache.org/jira/browse/CLOUDSTACK-5640


Repository: cloudstack-git


Description
-------

Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
Corrected the imports in 5 test suites which failed in recent build.


Diffs (updated)
-----

  test/integration/component/test_memory_limits.py 7da85a5 
  test/integration/component/test_security_groups.py c90ccf6 
  test/integration/component/test_snapshots_improvement.py 190db55 
  test/integration/component/test_vmware_drs.py 8eeb2c3 

Diff: https://reviews.apache.org/r/16481/diff/


Testing
-------

Tested using command "python test_suite_name.py"


Thanks,

Gaurav Aradhye

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/#review30932
-----------------------------------------------------------


Commit 6ad27d903b1ccfd0aac6cb1f304aabe7af1275e1 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6ad27d9 ]

CLOUDSTACK-5640: Correcting imports in test cases


- ASF Subversion and Git Services


On Dec. 27, 2013, 9:09 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16481/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 9:09 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5640
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
> Corrected the imports in 5 test suites which failed in recent build.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py 919725f 
>   test/integration/component/test_haproxy.py 1c8dc63 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 8910b2e 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py a08537e 
>   test/integration/smoke/test_service_offerings.py 22273d7 
> 
> Diff: https://reviews.apache.org/r/16481/diff/
> 
> 
> Testing
> -------
> 
> Tested using command "python test_suite_name.py"
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/#review30933
-----------------------------------------------------------


Commit 278b2b1b6661f8c77d5e583fd64137702dd13240 in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=278b2b1 ]

CLOUDSTACK-5640: Correcting imports in test cases


- ASF Subversion and Git Services


On Dec. 27, 2013, 9:09 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16481/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 9:09 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5640
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
> Corrected the imports in 5 test suites which failed in recent build.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py 919725f 
>   test/integration/component/test_haproxy.py 1c8dc63 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 8910b2e 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py a08537e 
>   test/integration/smoke/test_service_offerings.py 22273d7 
> 
> Diff: https://reviews.apache.org/r/16481/diff/
> 
> 
> Testing
> -------
> 
> Tested using command "python test_suite_name.py"
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/#review30934
-----------------------------------------------------------

Ship it!


Commited to 4.3 and master

- Girish Shilamkar


On Dec. 27, 2013, 9:09 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16481/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 9:09 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5640
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test suites are failing due to error in imports. These failures are represented by a generic message "sequence item 0: expected string, NoneType found".
> Corrected the imports in 5 test suites which failed in recent build.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py 919725f 
>   test/integration/component/test_haproxy.py 1c8dc63 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 8910b2e 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py a08537e 
>   test/integration/smoke/test_service_offerings.py 22273d7 
> 
> Diff: https://reviews.apache.org/r/16481/diff/
> 
> 
> Testing
> -------
> 
> Tested using command "python test_suite_name.py"
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>