[GitHub] [hadoop] jojochuang commented on issue #997: [HDFS-14585]Backport HDFS-8901 Use ByteBuffer in striping positional read to bran…

[GitBox <gi...@apache.org>]

jojochuang commented on issue #997: [HDFS-14585]Backport HDFS-8901 Use ByteBuffer in striping positional read to bran…
URL: https://github.com/apache/hadoop/pull/997#issuecomment-504307985
 
 
   Copying&Updating my comments from the [jira](https://issues.apache.org/jira/browse/HDFS-14585?focusedCommentId=16869186&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16869186)
   
   Hi Lisheng Sun We typically backport from the newer branches to older branches.
   The branch-2.8 is the oldest active branch. Would you please rebase on branch-2?
   Branch-2.8 is near EOL. There's no point backporting something from branch-3.x just for branch-2.8
   
   asflicense warning is false alarm. There are minor checkstyle warning that can be cleaned easily. The findbugs warning looks fishy. Looking back in my mailbox, the same warning came out a few times for branch-2. So probably unrelated, but we should file a jira for that.
   
   Suggest to update the jira summary, as this is essentially a reimplementation of HDFS-8901 for replicated blocks. Hadoop 2 does not support EC, and so there's no need to support striped blocks. How about "Reimplement HDFS-8901 for replicated block positional read in branch-2"?
   It is confusing if the jira summary is not updated to reflect the fact that striped blocks are not included.
   
   Do we need any test? Or is this purely an performance improvement and existing tests cover it all?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org