You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/11/04 04:52:43 UTC
Review Request 27561: Views: creating instance of same name overwrites
existing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27561/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-8136
https://issues.apache.org/jira/browse/AMBARI-8136
Repository: ambari
Description
-------
Attempt to create an existing view instance fails as expected but updates in-memory representation of the existing instance.
STR:
1. create view instance JOBS1
2. save, success
3. attempt to create another view instance and call it JOBS1
4. You are shown an error since the instance name needs to be unique. And API is showing a conflict. All that seems correct. Except, it overwrites all the view properties: display name, description, config params, etc. So I lost all my original settings.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 3d7f6db
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java a8b4c8d
Diff: https://reviews.apache.org/r/27561/diff/
Testing
-------
Results :
Tests run: 2192, Failures: 0, Errors: 0, Skipped: 14
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:01 min
[INFO] Finished at: 2014-11-03T22:37:42-05:00
[INFO] Final Memory: 39M/313M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 27561: Views: creating instance of same name
overwrites existing
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27561/#review59724
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 4, 2014, 3:52 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27561/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 3:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8136
> https://issues.apache.org/jira/browse/AMBARI-8136
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Attempt to create an existing view instance fails as expected but updates in-memory representation of the existing instance.
>
> STR:
> 1. create view instance JOBS1
> 2. save, success
> 3. attempt to create another view instance and call it JOBS1
> 4. You are shown an error since the instance name needs to be unique. And API is showing a conflict. All that seems correct. Except, it overwrites all the view properties: display name, description, config params, etc. So I lost all my original settings.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 3d7f6db
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java a8b4c8d
>
> Diff: https://reviews.apache.org/r/27561/diff/
>
>
> Testing
> -------
>
>
> Results :
>
> Tests run: 2192, Failures: 0, Errors: 0, Skipped: 14
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:01 min
> [INFO] Finished at: 2014-11-03T22:37:42-05:00
> [INFO] Final Memory: 39M/313M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>