You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2014/12/16 13:12:23 UTC
Review Request 29095: Adding wait till instance goes into running for
tests in falcon trunk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29095/
-----------------------------------------------------------
Review request for Falcon and samarth gupta.
Repository: falcon-git
Description
-------
Tetsed falcon regression for falcon trunk 0.7. The following test cases were failing as they were not waiting for instance to reach running state. Added the patch for them
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 53054c61
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 74ff0b9
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java f3bb4a3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 6f88103
Diff: https://reviews.apache.org/r/29095/diff/
Testing
-------
Test cases are :
1.ProcessInstanceRunningTest .getRunningProcessInstance
2.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEndCheckNoInstanceAfterEndDate
3.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEnd
4.ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded
5.ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
6.ProcessInstanceKillsTest.testProcessInstanceKillSingle
7.ProcessInstanceKillsTest.testProcessInstanceKillSuspended
Thanks,
PRAGYA MITTAL
Re: Review Request 29095: Adding wait till instance goes into running
for tests in falcon trunk
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29095/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 8:51 a.m.)
Review request for Falcon and samarth gupta.
Bugs: FALCON-951
https://issues.apache.org/jira/browse/FALCON-951
Repository: falcon-git
Description
-------
Tetsed falcon regression for falcon trunk 0.7. The following test cases were failing as they were not waiting for instance to reach running state. Added the patch for them
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 53054c61
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 74ff0b9
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java f3bb4a3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 6f88103
Diff: https://reviews.apache.org/r/29095/diff/
Testing
-------
Test cases are :
1.ProcessInstanceRunningTest .getRunningProcessInstance
2.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEndCheckNoInstanceAfterEndDate
3.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEnd
4.ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded
5.ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
6.ProcessInstanceKillsTest.testProcessInstanceKillSingle
7.ProcessInstanceKillsTest.testProcessInstanceKillSuspended
File Attachments
----------------
Updated Patch
https://reviews.apache.org/media/uploaded/files/2014/12/18/8a8f80fe-69e1-4437-b928-595dd2b95b92__FALCON-951_v1.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 29095: Adding wait till instance goes into running
for tests in falcon trunk
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29095/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 6:37 a.m.)
Review request for Falcon and samarth gupta.
Changes
-------
Removed sleep time from ProcessInstanceKillsTest
Repository: falcon-git
Description
-------
Tetsed falcon regression for falcon trunk 0.7. The following test cases were failing as they were not waiting for instance to reach running state. Added the patch for them
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 53054c61
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 74ff0b9
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java f3bb4a3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 6f88103
Diff: https://reviews.apache.org/r/29095/diff/
Testing
-------
Test cases are :
1.ProcessInstanceRunningTest .getRunningProcessInstance
2.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEndCheckNoInstanceAfterEndDate
3.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEnd
4.ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded
5.ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
6.ProcessInstanceKillsTest.testProcessInstanceKillSingle
7.ProcessInstanceKillsTest.testProcessInstanceKillSuspended
File Attachments (updated)
----------------
Updated Patch
https://reviews.apache.org/media/uploaded/files/2014/12/18/8a8f80fe-69e1-4437-b928-595dd2b95b92__FALCON-951_v1.patch
Thanks,
PRAGYA MITTAL
Re: Review Request 29095: Adding wait till instance goes into running
for tests in falcon trunk
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29095/#review65239
-----------------------------------------------------------
+1 after review comments are addressed
- Raghav Gautam
On Dec. 16, 2014, 4:12 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29095/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 4:12 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tetsed falcon regression for falcon trunk 0.7. The following test cases were failing as they were not waiting for instance to reach running state. Added the patch for them
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 53054c61
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 74ff0b9
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java f3bb4a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 6f88103
>
> Diff: https://reviews.apache.org/r/29095/diff/
>
>
> Testing
> -------
>
> Test cases are :
> 1.ProcessInstanceRunningTest .getRunningProcessInstance
> 2.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEndCheckNoInstanceAfterEndDate
> 3.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEnd
> 4.ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded
> 5.ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
> 6.ProcessInstanceKillsTest.testProcessInstanceKillSingle
> 7.ProcessInstanceKillsTest.testProcessInstanceKillSuspended
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 29095: Adding wait till instance goes into running
for tests in falcon trunk
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29095/#review65470
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
<https://reviews.apache.org/r/29095/#comment108639>
That can be done.As it is now waiting for instance to go into running mode, no need for applying sleep.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
<https://reviews.apache.org/r/29095/#comment108640>
As mentioned above we can remove this. Will update the new changes.
- PRAGYA MITTAL
On Dec. 16, 2014, 12:12 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29095/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 12:12 p.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tetsed falcon regression for falcon trunk 0.7. The following test cases were failing as they were not waiting for instance to reach running state. Added the patch for them
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 53054c61
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 74ff0b9
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java f3bb4a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 6f88103
>
> Diff: https://reviews.apache.org/r/29095/diff/
>
>
> Testing
> -------
>
> Test cases are :
> 1.ProcessInstanceRunningTest .getRunningProcessInstance
> 2.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEndCheckNoInstanceAfterEndDate
> 3.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEnd
> 4.ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded
> 5.ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
> 6.ProcessInstanceKillsTest.testProcessInstanceKillSingle
> 7.ProcessInstanceKillsTest.testProcessInstanceKillSuspended
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 29095: Adding wait till instance goes into running
for tests in falcon trunk
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29095/#review65238
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
<https://reviews.apache.org/r/29095/#comment108275>
can we get rid of the sleep ?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
<https://reviews.apache.org/r/29095/#comment108276>
can we get rid of the sleep ?
- Raghav Gautam
On Dec. 16, 2014, 4:12 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29095/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 4:12 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tetsed falcon regression for falcon trunk 0.7. The following test cases were failing as they were not waiting for instance to reach running state. Added the patch for them
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 53054c61
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 74ff0b9
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java f3bb4a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 6f88103
>
> Diff: https://reviews.apache.org/r/29095/diff/
>
>
> Testing
> -------
>
> Test cases are :
> 1.ProcessInstanceRunningTest .getRunningProcessInstance
> 2.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEndCheckNoInstanceAfterEndDate
> 3.ProcessInstanceStatusTest.testProcessInstanceStatusStartAndEnd
> 4.ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded
> 5.ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded
> 6.ProcessInstanceKillsTest.testProcessInstanceKillSingle
> 7.ProcessInstanceKillsTest.testProcessInstanceKillSuspended
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>