You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/07 22:45:08 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #1310: Spark: Use SessionState to load Hadoop config
aokolnychyi opened a new pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310
We have to use `SessionState` to get a complete Hadoop conf. It is legal to set Hadoop properties directly without the `spark.hadoop` prefix. If we use `SparkContext` directly, we will miss such properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#discussion_r467317760
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -443,6 +443,7 @@ private Schema lazyExpectedSchema() {
return expectedSchema;
}
+ @SuppressWarnings("checkstyle:RegexpSingleline")
Review comment:
I think we can address that in a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#discussion_r467323290
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -443,6 +443,7 @@ private Schema lazyExpectedSchema() {
return expectedSchema;
}
+ @SuppressWarnings("checkstyle:RegexpSingleline")
Review comment:
I think this is fixed in the Spark 3 path, where we use FileIO instead of creating a file system directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#issuecomment-670787801
Oops, I'll have to update usages in tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#issuecomment-670773678
cc @rdblue @RussellSpitzer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#discussion_r467317032
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -443,6 +443,7 @@ private Schema lazyExpectedSchema() {
return expectedSchema;
}
+ @SuppressWarnings("checkstyle:RegexpSingleline")
Review comment:
I kept the current implementation as `sessionState().newHadoopConf()` is more expensive. I think the correct fix here would be to broadcast the Hadoop conf. We already do that while broadcasting `FileIO`, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#issuecomment-670779639
+1 when tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1310: Spark: Use SessionState to load Hadoop config
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1310:
URL: https://github.com/apache/iceberg/pull/1310#discussion_r467323672
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -443,6 +443,7 @@ private Schema lazyExpectedSchema() {
return expectedSchema;
}
+ @SuppressWarnings("checkstyle:RegexpSingleline")
Review comment:
Let's leave it as is then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org