You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pgandhi999 <gi...@git.apache.org> on 2017/07/31 21:41:19 UTC
[GitHub] spark pull request #18788: [SPARK-21585]: Application Master marking applica...
GitHub user pgandhi999 opened a pull request:
https://github.com/apache/spark/pull/18788
[SPARK-21585]: Application Master marking application status as Failed for Client Mode
The fix deployed for SPARK-21541 resulted in the Application Master to set the final status of a spark application as Failed for the client mode as the flag 'registered' was not being set to true for client mode. So, in order to fix the issue, I have set the flag 'registered' as true in client mode on successfully registering Application Master.
## How was this patch tested?
Tested the patch manually.
Before:
<img width="1275" alt="screen shot-before2" src="https://user-images.githubusercontent.com/22228190/28799641-02b5ed78-760f-11e7-9eb0-bf8407dad0ad.png">
After:
<img width="1221" alt="screen shot-after2" src="https://user-images.githubusercontent.com/22228190/28799646-0ac9ef14-760f-11e7-8bf5-9dfd743d0f2f.png">
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pgandhi999/spark SPARK-21585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18788
----
commit 172fc20898896058b7288360eb5292ed9df9d79c
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-21T21:00:22Z
[SPARK-21503]: Fixed the issue
Added the case ExecutorLostFailure which was previously not there, thus, the default case would be executed in which case, task would be marked as completed.
commit 81422e0f634c0f06eb2ea29fba4281176a1ab528
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-25T14:54:41Z
[SPARK-21503][UI]: Adding changes as per comments
commit 55c6c37d09b41ae6914edb5d067e7f2c252ac92a
Author: pgandhi999 <pa...@gmail.com>
Date: 2017-07-26T21:26:27Z
Merge pull request #1 from apache/master
Apache Spark Pull Request - July 26, 2017
commit f454c8933e07967548095e068063bd313ae4845c
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-26T21:41:16Z
[SPARK-21541]: Spark Logs show incorrect job status for a job that does not create SparkContext
Added a flag to check whether user has initialized Spark Context. If it is true, then we let Application Master unregister with Resource Manager else we do not.
commit 6b7d5c6e2565c7c4dd97f31fe404c59e73c7474c
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-26T21:58:27Z
Revert "[SPARK-21541]: Spark Logs show incorrect job status for a job that does not create SparkContext"
This reverts commit f454c8933e07967548095e068063bd313ae4845c.
"Merged another issue to this one by mistake"
commit 5c52c72949efdf14a40ff60e8edbe98e011bc084
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-26T22:23:30Z
[SPARK-21541]: Making Changes
Added a flag to check whether user has initialized SparkContext. If it is true, we let Application Master unregister with Resource Manager else, we do not let AM unregister with RM.
commit cfd9f71497c5411f697555c9d604923d998cf406
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-26T22:40:34Z
Reverting Commits from Master Branch
commit 0e4228cfe721fd9a32f8b0b1e3fa7ad0f16d480d
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-27T00:18:08Z
Made changes according to scalastyle format
commit 3e0d1aef4c1fe5f6d04e1bdad43cd28f03ad1fbf
Author: pgandhi <pg...@yahoo-inc.com>
Date: 2017-07-31T20:58:04Z
[SPARK-21585]: Application Master marking application status as Failed for Client Mode
[SPARK-21585]: Application Master marking application status as Failed for Client Mode - Setting the flag 'registered' as true in client mode on successfully registering Application Master.
commit 63e01b8b78ce33ea938941467dc44dd050ca8a84
Author: pgandhi999 <pa...@gmail.com>
Date: 2017-07-31T21:00:40Z
Merge pull request #3 from apache/master
Spark - July 31, 2017
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18788
**[Test build #80095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80095/testReport)** for PR 18788 at commit [`63e01b8`](https://github.com/apache/spark/commit/63e01b8b78ce33ea938941467dc44dd050ca8a84).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class OneVsRestParams(HasFeaturesCol, HasLabelCol, HasWeightCol, HasPredictionCol):`
* `case class UnresolvedSubqueryColumnAliases(`
* `sealed trait FrameType `
* `sealed trait SpecialFrameBoundary extends Expression with Unevaluable `
* `sealed trait WindowFrame extends Expression with Unevaluable `
* `class ArrowWriter(`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18788
**[Test build #80095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80095/testReport)** for PR 18788 at commit [`63e01b8`](https://github.com/apache/spark/commit/63e01b8b78ce33ea938941467dc44dd050ca8a84).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/18788
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18788: [SPARK-21585]: Application Master marking applica...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18788
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/18788
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18788
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/18788
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18788: [SPARK-21585]: Application Master marking application st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80095/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org