You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/08 04:41:33 UTC

[GitHub] [spark] KarlManong commented on a change in pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method

KarlManong commented on a change in pull request #32080:
URL: https://github.com/apache/spark/pull/32080#discussion_r609291585



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1031,6 +1031,8 @@ object SparkSubmit extends CommandLineUtils with Logging {
         } catch {
           case e: SparkUserAppException =>
             exitFn(e.exitCode)
+          case _: Throwable => 
+            exitFn(1)

Review comment:
       Yes, you are right.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org