You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/08 02:12:22 UTC
[GitHub] [skywalking-eyes] jmjoy opened a new pull request, #122: Add subcommand support for github actions.
jmjoy opened a new pull request, #122:
URL: https://github.com/apache/skywalking-eyes/pull/122
Usually CI not only needs to do `header check`, but also do `dep check`.
I added the `subcommand` argument to ensure compatibility, there may be a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] jmjoy commented on pull request #122: Add subcommand support for github actions.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #122:
URL: https://github.com/apache/skywalking-eyes/pull/122#issuecomment-1178468956
> This is not appropriate because when subcommand is `dependency`, `${{ inputs.mode }}` can be `fix`/`check`, but `dependency` has no subcommand `fix`, I was planning to have a dedicated GitHub action for dependency, in that action we can have more configurations specific to `dependency` command. If you don't mind I will open a PR to add the new GHA
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] jmjoy closed pull request #122: Add subcommand support for github actions.
Posted by GitBox <gi...@apache.org>.
jmjoy closed pull request #122: Add subcommand support for github actions.
URL: https://github.com/apache/skywalking-eyes/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org