[GitHub] StefanRRichter commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints

[GitBox <gi...@apache.org>]

StefanRRichter commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints
URL: https://github.com/apache/flink/pull/7515#issuecomment-461778016
 
 
   @Myasuka Thanks for the contribution. I have a high level comment that I would suggest an approach that could be a bit similar to what I suggested for RocksDB `OptionFactory` in your other PR.
   
   Instead of offering a fixed set of compression options as an enum, why not have a method in which the user can do `setStreamCompressionDecorator(StreamCompressionDecorator)`? On top of that, we can also allow to specifiy this class in the flink-conf, and code overrides conf if both are present. Like this, user can introduce their own compression schemes and we are not limiting to snappy or lz4. Snappy and LZ4 would then remain as two ready-to-use implementations. We can annotate the old methods of setting compression as depricated. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services