You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2016/06/10 21:39:03 UTC
[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test catalog service client.py.
David Knupp has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3366
Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
......................................................................
IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
Even though this is just a single test, this change introduces the
unique_database test fixture that was initially created to help with
concurrent tests. It's still worth to do this here because we want to
update all tests to use best practices.
That said, there was still a performance gain to be had here. It
turns out the initial code called the cleanup_db() method from the
base ImpalaTestSuite class, which in turn sets the 'sync_ddl' query
option to true. Not doing this at the beginning of this test results
in a roughly 40x speedup.
Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
---
M tests/catalog_service/test_catalog_service_client.py
1 file changed, 11 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/66/3366/1
--
To view, visit http://gerrit.cloudera.org:8080/3366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test catalog service client.py.
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
......................................................................
Patch Set 2: Code-Review+2
Rebase with no conflicts.
--
To view, visit http://gerrit.cloudera.org:8080/3366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test catalog service client.py.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
......................................................................
IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
Even though this is just a single test, this change introduces the
unique_database test fixture that was initially created to help with
concurrent tests. It's still worth to do this here because we want to
update all tests to use best practices.
That said, there was still a performance gain to be had here. It
turns out the initial code called the cleanup_db() method from the
base ImpalaTestSuite class, which in turn sets the 'sync_ddl' query
option to true. Not doing this at the beginning of this test results
in a roughly 40x speedup.
Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Reviewed-on: http://gerrit.cloudera.org:8080/3366
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/catalog_service/test_catalog_service_client.py
1 file changed, 11 insertions(+), 19 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test catalog service client.py.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
......................................................................
Patch Set 1: Code-Review+2
Completely agree with your rationale!
--
To view, visit http://gerrit.cloudera.org:8080/3366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test catalog service client.py.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No