You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Konrad Windszus <ko...@gmx.de> on 2019/09/10 07:12:21 UTC
[VOTE] Release Apache Jackrabbit Filevault 3.4.0
Hi,
A candidate for the Jackrabbit Filevault 3.4.0 release is available at:
https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.0/
The release candidate is a zip archive of the sources in:
https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/tags/jackrabbit-filevault-3.4.0/
The SHA1 checksum of the archive is 985878ce867b61af53d9b1ba1366b2d6bf7ac076.
The command for running automated checks against this release candidate is:
$ sh check-release.sh filevault 3.4.0 985878ce867b61af53d9b1ba1366b2d6bf7ac076
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachejackrabbit-1460
The fixed issues are listed in https://issues.apache.org/jira/projects/JCRVLT/versions/12345172.
Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.0.
The vote is open for a minimum of 72 hours during business days and passes
if a majority of at least three +1 Jackrabbit PMC votes are cast.
The vote fails if not enough votes are cast after 1 week (5 business days).
[ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.0
[ ] -1 Do not release this package because...
Thanks for voting,
Konrad
Re: [VOTE][RESULT] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
> On 13. Sep 2019, at 09:24, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi, The vote has passed with the following result :
>
> +1 (binding): Julian, Toby, Konrad
> +1 (non binding): none
>
> I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
>
> Thanks for voting,
> Konrad
>
>
If course I meant the Jackrabbit dist directory (not Sling)
@Robert: Thanks for the hint.
[VOTE][RESULT] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
Hi, The vote has passed with the following result :
+1 (binding): Julian, Toby, Konrad
+1 (non binding): none
I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
Thanks for voting,
Konrad
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Julian Reschke <ju...@gmx.de>.
On 10.09.2019 09:12, Konrad Windszus wrote:
> ...
[X] +1 Release this package as Apache Jackrabbit Filevault 3.4.0
...where...
> [INFO] Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00)
> [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> [INFO] Java version: 1.8.0_221, vendor: Oracle Corporation
> [INFO] MAVEN_OPTS: -Xmx2g
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Tobias Bocanegra <tr...@adobe.com>.
Here's my vote:
[x] +1 Release this package as Apache Jackrabbit Filevault 3.4.0
With:
[INFO] ------------------------------------------------------------------------
[INFO] Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-05T04:00:29+09:00)
[INFO] OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
[INFO] Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre
[INFO] MAVEN_OPTS:
[INFO] ------------------------------------------------------------------------
[INFO] ALL CHECKS OK
[INFO] ------------------------------------------------------------------------
> On 10 Sep 2019, at 16:12, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi,
>
> A candidate for the Jackrabbit Filevault 3.4.0 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.0/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/tags/jackrabbit-filevault-3.4.0/
>
> The SHA1 checksum of the archive is 985878ce867b61af53d9b1ba1366b2d6bf7ac076.
>
> The command for running automated checks against this release candidate is:
> $ sh check-release.sh filevault 3.4.0 985878ce867b61af53d9b1ba1366b2d6bf7ac076
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachejackrabbit-1460
>
> The fixed issues are listed in https://issues.apache.org/jira/projects/JCRVLT/versions/12345172.
>
> Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.0.
> The vote is open for a minimum of 72 hours during business days and passes
> if a majority of at least three +1 Jackrabbit PMC votes are cast.
> The vote fails if not enough votes are cast after 1 week (5 business days).
>
> [ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.0
> [ ] -1 Do not release this package because...
>
> Thanks for voting,
> Konrad
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
Here is my +1
[INFO] ------------------------------------------------------------------------
[INFO] Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
[INFO] OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
[INFO] Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre
[INFO] MAVEN_OPTS:
[INFO] ------------------------------------------------------------------------
[INFO] ALL CHECKS OK
[INFO] ------------------------------------------------------------------------
Konrad
> On 10. Sep 2019, at 09:12, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi,
>
> A candidate for the Jackrabbit Filevault 3.4.0 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.0/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/commons/filevault/tags/jackrabbit-filevault-3.4.0/
>
> The SHA1 checksum of the archive is 985878ce867b61af53d9b1ba1366b2d6bf7ac076.
>
> The command for running automated checks against this release candidate is:
> $ sh check-release.sh filevault 3.4.0 985878ce867b61af53d9b1ba1366b2d6bf7ac076
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachejackrabbit-1460
>
> The fixed issues are listed in https://issues.apache.org/jira/projects/JCRVLT/versions/12345172.
>
> Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.0.
> The vote is open for a minimum of 72 hours during business days and passes
> if a majority of at least three +1 Jackrabbit PMC votes are cast.
> The vote fails if not enough votes are cast after 1 week (5 business days).
>
> [ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.0
> [ ] -1 Do not release this package because...
>
> Thanks for voting,
> Konrad
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
Ok, I committed the changes to check-release.sh and now the checks are successful.
Konrad
> On 11. Sep 2019, at 01:36, Tobias Bocanegra <tr...@adobe.com> wrote:
>
> Hi Konrad,
>
> Thanks for looking into it. Let's fix the check.sh and continue with the release then....
> Regards, Toby
>
>> On 11 Sep 2019, at 00:48, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>
>> Ok, got it.
>> Jackrabbit Oak is not running into the same issue (although also having the .gitignore) because the check-release.sh (https://dist.apache.org/repos/dist/dev/jackrabbit/check-release.sh <https://dist.apache.org/repos/dist/dev/jackrabbit/check-release.sh>) has a flaw:
>> CLEAN_SVN is including ".gitignore" for component "filevault-package-maven-plugin" and in case no
>> component is given, but not for component "jackrabbit-filevault".
>> @Toby: I guess this was just a copy&paste error and not a deliberate decision?
>>
>> Is everyone fine with not overwriting CLEAN_SVN for the component "filevault-package-maven-plugin"?
>> Thanks,
>> Konrad
>>
>>> On 10. Sep 2019, at 15:35, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>>
>>> This is definitely the maven-assemly-plugin which does some excludes by default (https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore <https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore>, http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet <http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet>).
>>> But just using useDefaultExcludes=false is not working either because that will include the .svn folder as well. So I need to imitate all default excludes except for .gitignore...
>>>
>>> I am still wondering why that was not a problem in the past, because the .gitignore file is quite old (from 2013, https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore <https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore>)
>>> Konrad
>>>
>>>> On 10. Sep 2019, at 15:15, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>>>
>>>> Hi Toby
>>>> I checked again:
>>>>
>>>> .gitignore is part of the trunk: http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore <http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore> but for some reason it is not contained in the source zip folder.
>>>> Just removing .gitgnore from the tag seems wrong to me, the correct fix would be to make sure .gitignore is also part of the zip file.
>>>>
>>>> Any idea where the filter is configured for the src zip?
>>>>
>>>> Thanks,
>>>> Konrad
>>>>
>>>>
>>>>> On 10. Sep 2019, at 10:30, Tobias Bocanegra <tripod@adobe.com <ma...@adobe.com>> wrote:
>>>>>
>>>>>
>>>>>> On 10 Sep 2019, at 17:16, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>>>>>
>>>>>> Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
>>>>>> The FileVault introduces a JCR repository to filesystem mapping. The mapping
>>>>>> is exposed by and API and used by the _CRX Content Packaging_ that allows to
>>>>>> create portable packages of repository content.
>>>>>
>>>>>
>>>>> This is the original text for ages :-) I think it should read:
>>>>>
>>>>>> The mapping is exposed by an API
>>>>> ^^
>>>>>>
>>>>>>
>>>>>> Probably this should be reworked. Can you help with that?
>>>>>>
>>>>>> Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
>>>>>>
>>>>>> Do you want me to Cance the vote and restart?
>>>>>
>>>>> If you modify the release notes, you need to restart the release.
>>>>>
>>>>>> If I restart, can I reuse version 3.4.0?
>>>>>
>>>>> It's better to use a new version number (3.4.2) , so it's clear and transparent.
>>>>>
>>>>> Regards, Toby
>>>>
>>>
>>
>
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Tobias Bocanegra <tr...@adobe.com>.
Hi Konrad,
Thanks for looking into it. Let's fix the check.sh and continue with the release then....
Regards, Toby
On 11 Sep 2019, at 00:48, Konrad Windszus <ko...@gmx.de>> wrote:
Ok, got it.
Jackrabbit Oak is not running into the same issue (although also having the .gitignore) because the check-release.sh (https://dist.apache.org/repos/dist/dev/jackrabbit/check-release.sh) has a flaw:
CLEAN_SVN is including ".gitignore" for component "filevault-package-maven-plugin" and in case no component is given, but not for component "jackrabbit-filevault".
@Toby: I guess this was just a copy&paste error and not a deliberate decision?
Is everyone fine with not overwriting CLEAN_SVN for the component "filevault-package-maven-plugin"?
Thanks,
Konrad
On 10. Sep 2019, at 15:35, Konrad Windszus <ko...@gmx.de>> wrote:
This is definitely the maven-assemly-plugin which does some excludes by default (https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore, http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet).
But just using useDefaultExcludes=false is not working either because that will include the .svn folder as well. So I need to imitate all default excludes except for .gitignore...
I am still wondering why that was not a problem in the past, because the .gitignore file is quite old (from 2013, https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore)
Konrad
On 10. Sep 2019, at 15:15, Konrad Windszus <ko...@gmx.de>> wrote:
Hi Toby
I checked again:
.gitignore is part of the trunk: http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore but for some reason it is not contained in the source zip folder.
Just removing .gitgnore from the tag seems wrong to me, the correct fix would be to make sure .gitignore is also part of the zip file.
Any idea where the filter is configured for the src zip?
Thanks,
Konrad
On 10. Sep 2019, at 10:30, Tobias Bocanegra <tr...@adobe.com>> wrote:
On 10 Sep 2019, at 17:16, Konrad Windszus <ko...@gmx.de>> wrote:
Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
The FileVault introduces a JCR repository to filesystem mapping. The mapping
is exposed by and API and used by the _CRX Content Packaging_ that allows to
create portable packages of repository content.
This is the original text for ages :-) I think it should read:
The mapping is exposed by an API
^^
Probably this should be reworked. Can you help with that?
Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
Do you want me to Cance the vote and restart?
If you modify the release notes, you need to restart the release.
If I restart, can I reuse version 3.4.0?
It's better to use a new version number (3.4.2) , so it's clear and transparent.
Regards, Toby
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
Ok, got it.
Jackrabbit Oak is not running into the same issue (although also having the .gitignore) because the check-release.sh (https://dist.apache.org/repos/dist/dev/jackrabbit/check-release.sh <https://dist.apache.org/repos/dist/dev/jackrabbit/check-release.sh>) has a flaw:
CLEAN_SVN is including ".gitignore" for component "filevault-package-maven-plugin" and in case no component is given, but not for component "jackrabbit-filevault".
@Toby: I guess this was just a copy&paste error and not a deliberate decision?
Is everyone fine with not overwriting CLEAN_SVN for the component "filevault-package-maven-plugin"?
Thanks,
Konrad
> On 10. Sep 2019, at 15:35, Konrad Windszus <ko...@gmx.de> wrote:
>
> This is definitely the maven-assemly-plugin which does some excludes by default (https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore <https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore>, http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet <http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet>).
> But just using useDefaultExcludes=false is not working either because that will include the .svn folder as well. So I need to imitate all default excludes except for .gitignore...
>
> I am still wondering why that was not a problem in the past, because the .gitignore file is quite old (from 2013, https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore <https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore>)
> Konrad
>
>> On 10. Sep 2019, at 15:15, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>
>> Hi Toby
>> I checked again:
>>
>> .gitignore is part of the trunk: http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore <http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore> but for some reason it is not contained in the source zip folder.
>> Just removing .gitgnore from the tag seems wrong to me, the correct fix would be to make sure .gitignore is also part of the zip file.
>>
>> Any idea where the filter is configured for the src zip?
>>
>> Thanks,
>> Konrad
>>
>>
>>> On 10. Sep 2019, at 10:30, Tobias Bocanegra <tripod@adobe.com <ma...@adobe.com>> wrote:
>>>
>>>
>>>> On 10 Sep 2019, at 17:16, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>>>
>>>> Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
>>>> The FileVault introduces a JCR repository to filesystem mapping. The mapping
>>>> is exposed by and API and used by the _CRX Content Packaging_ that allows to
>>>> create portable packages of repository content.
>>>
>>>
>>> This is the original text for ages :-) I think it should read:
>>>
>>>> The mapping is exposed by an API
>>> ^^
>>>>
>>>>
>>>> Probably this should be reworked. Can you help with that?
>>>>
>>>> Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
>>>>
>>>> Do you want me to Cance the vote and restart?
>>>
>>> If you modify the release notes, you need to restart the release.
>>>
>>>> If I restart, can I reuse version 3.4.0?
>>>
>>> It's better to use a new version number (3.4.2) , so it's clear and transparent.
>>>
>>> Regards, Toby
>>
>
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
This is definitely the maven-assemly-plugin which does some excludes by default (https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore <https://stackoverflow.com/questions/31550974/maven-assembly-plugin-excludes-gitignore>, http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet <http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet>).
But just using useDefaultExcludes=false is not working either because that will include the .svn folder as well. So I need to imitate all default excludes except for .gitignore...
I am still wondering why that was not a problem in the past, because the .gitignore file is quite old (from 2013, https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore <https://github.com/apache/jackrabbit-filevault/blob/trunk/.gitignore>)
Konrad
> On 10. Sep 2019, at 15:15, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi Toby
> I checked again:
>
> .gitignore is part of the trunk: http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore <http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore> but for some reason it is not contained in the source zip folder.
> Just removing .gitgnore from the tag seems wrong to me, the correct fix would be to make sure .gitignore is also part of the zip file.
>
> Any idea where the filter is configured for the src zip?
>
> Thanks,
> Konrad
>
>
>> On 10. Sep 2019, at 10:30, Tobias Bocanegra <tripod@adobe.com <ma...@adobe.com>> wrote:
>>
>>
>>> On 10 Sep 2019, at 17:16, Konrad Windszus <konrad_w@gmx.de <ma...@gmx.de>> wrote:
>>>
>>> Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
>>> The FileVault introduces a JCR repository to filesystem mapping. The mapping
>>> is exposed by and API and used by the _CRX Content Packaging_ that allows to
>>> create portable packages of repository content.
>>
>>
>> This is the original text for ages :-) I think it should read:
>>
>>> The mapping is exposed by an API
>> ^^
>>>
>>>
>>> Probably this should be reworked. Can you help with that?
>>>
>>> Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
>>>
>>> Do you want me to Cance the vote and restart?
>>
>> If you modify the release notes, you need to restart the release.
>>
>>> If I restart, can I reuse version 3.4.0?
>>
>> It's better to use a new version number (3.4.2) , so it's clear and transparent.
>>
>> Regards, Toby
>
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
Hi Toby
I checked again:
.gitignore is part of the trunk: http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore <http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/trunk/.gitignore> but for some reason it is not contained in the source zip folder.
Just removing .gitgnore from the tag seems wrong to me, the correct fix would be to make sure .gitignore is also part of the zip file.
Any idea where the filter is configured for the src zip?
Thanks,
Konrad
> On 10. Sep 2019, at 10:30, Tobias Bocanegra <tr...@adobe.com> wrote:
>
>
>> On 10 Sep 2019, at 17:16, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
>> The FileVault introduces a JCR repository to filesystem mapping. The mapping
>> is exposed by and API and used by the _CRX Content Packaging_ that allows to
>> create portable packages of repository content.
>
>
> This is the original text for ages :-) I think it should read:
>
>> The mapping is exposed by an API
> ^^
>>
>>
>> Probably this should be reworked. Can you help with that?
>>
>> Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
>>
>> Do you want me to Cance the vote and restart?
>
> If you modify the release notes, you need to restart the release.
>
>> If I restart, can I reuse version 3.4.0?
>
> It's better to use a new version number (3.4.2) , so it's clear and transparent.
>
> Regards, Toby
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Tobias Bocanegra <tr...@adobe.com>.
> On 10 Sep 2019, at 17:16, Konrad Windszus <ko...@gmx.de> wrote:
>
> Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
> The FileVault introduces a JCR repository to filesystem mapping. The mapping
> is exposed by and API and used by the _CRX Content Packaging_ that allows to
> create portable packages of repository content.
This is the original text for ages :-) I think it should read:
> The mapping is exposed by an API
^^
>
>
> Probably this should be reworked. Can you help with that?
>
> Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
>
> Do you want me to Cance the vote and restart?
If you modify the release notes, you need to restart the release.
> If I restart, can I reuse version 3.4.0?
It's better to use a new version number (3.4.2) , so it's clear and transparent.
Regards, Toby
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Konrad Windszus <ko...@gmx.de>.
Yes, release notes are unfortunately not correct. The introduction text is also quite weird:
The FileVault introduces a JCR repository to filesystem mapping. The mapping
is exposed by and API and used by the _CRX Content Packaging_ that allows to
create portable packages of repository content.
The Vault Command Line Interface aka _vlt_ that provides a subversion like
utility to work and develop with repository content.
Probably this should be reworked. Can you help with that?
Regarding .gitignore I could manually remove it from the tag, this is probably because I first started the release on the git svn working copy.
Do you want me to Cance the vote and restart?
If I restart, can I reuse version 3.4.0?
Thanks,
Konrad
> On 10. Sep 2019, at 10:11, Tobias Bocanegra <tr...@adobe.com> wrote:
>
> Hmm...
>
>> On 10 Sep 2019, at 16:12, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> sh check-release.sh filevault 3.4.0 985878ce867b61af53d9b1ba1366b2d6bf7ac076
>
> This fails for me with:
>
> 1 Only in ./target/jackrabbit-filevault-3.4.0/svn/jackrabbit-filevault-3.4.0: .gitignore
> 154 [ERROR] NOT OK: Tagged sources are different from those in the archive
>
> IIRC, we had some problems with .gitignore files before...I think it is not included in the zip.
> The simplest would be to remove it from the tag for now....
>
>
> Also, the release notes still show he 3.2.8 version (first line):
> https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.0/RELEASE-NOTES.txt
>
> Regards, Toby
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.0
Posted by Tobias Bocanegra <tr...@adobe.com>.
Hmm...
> On 10 Sep 2019, at 16:12, Konrad Windszus <ko...@gmx.de> wrote:
>
> sh check-release.sh filevault 3.4.0 985878ce867b61af53d9b1ba1366b2d6bf7ac076
This fails for me with:
1 Only in ./target/jackrabbit-filevault-3.4.0/svn/jackrabbit-filevault-3.4.0: .gitignore
154 [ERROR] NOT OK: Tagged sources are different from those in the archive
IIRC, we had some problems with .gitignore files before...I think it is not included in the zip.
The simplest would be to remove it from the tag for now....
Also, the release notes still show he 3.2.8 version (first line):
https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.0/RELEASE-NOTES.txt
Regards, Toby