You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/07/08 08:39:55 UTC
[GitHub] zeppelin pull request #1153: Block all routes except Home when user isn't lo...
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1153
Block all routes except Home when user isn't logged
### What is this PR for?
When user isn't logged while the auth is activated, we are hiding the notebooks and most of the menus.
However you can still access them using the url routes.
This PR is blocking the url routes except the home route ('/') in that case.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1123
### How should this be tested?
* Activate the auth in shiro.ini
* Launch Zeppelin, and try to visit `localhost:8080/#/interpreter` by typing it in your browser
* You should be redirected to '/'
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1153
----
commit 76eac8cd25dc84cf842247d8fb1a87cfda31bf2e
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-08T08:32:09Z
Block all routes except Home when user isn't logged
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1153: Block all routes except Home when user isn't logged
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1153
CI doesn't seem related, but still gonna retrigger it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1153: Block all routes except Home when user isn't logged
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1153
Ci is green, merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1153: Block all routes except Home when user isn't logged
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1153
Tried new changes works well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1153: Block all routes except Home when user isn't lo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1153: Block all routes except Home when user isn't logged
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1153
LGTM! minor suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1153: Block all routes except Home when user isn't lo...
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1153
Block all routes except Home when user isn't logged
### What is this PR for?
When user isn't logged while the auth is activated, we are hiding the notebooks and most of the menus.
However you can still access them using the url routes.
This PR is blocking the url routes except the home route ('/') in that case.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1123
### How should this be tested?
* Activate the auth in shiro.ini
* Launch Zeppelin, and try to visit `localhost:8080/#/interpreter` by typing it in your browser
* You should be redirected to '/'
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1153
----
commit ebb9136551530e1f3a9b3cb3310c1fcc4732e809
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-08T08:32:09Z
Block all routes except Home when user isn't logged
commit 58c5a6eab59113bc40cb969be4ac9a505ad77aa9
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-11T07:02:34Z
Remove preventDefault
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1153: Block all routes except Home when user isn't lo...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---