You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/06/12 00:42:15 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2354: Fix for reading multirow datatable entry reads non-belonging entry
josehernandezfintecheandomx opened a new pull request, #2354:
URL: https://github.com/apache/fineract/pull/2354
## Description
The endpoint `datatables/{datatable}/{apptableId}/{datatableId}` was not honoring `appTableId` path param when `datatableId` is not null in request. This results in API allowing access to a datatableId that belongs to a different apptableId.
This only was for _multirow_ datatable and It was giving priority only to the datatable record Id instead of the relationship between `apptableId` (entity Id) and the `datatableId` (record Id)
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2354: Fix for reading multirow datatable entry reads non-belonging entry
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2354:
URL: https://github.com/apache/fineract/pull/2354#discussion_r895685211
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1304,18 +1334,19 @@ private GenericResultsetData retrieveDataTableGenericResultSetForUpdate(final St
final List<ResultsetColumnHeaderData> columnHeaders = this.genericDataService.fillResultsetColumnHeaders(dataTableName);
- String sql = "";
+ final boolean multiRow = isMultirowDatatable(columnHeaders);
- // id only used for reading a specific entry in a one to many datatable
- // (when updating)
- if (id == null) {
- String whereClause = getFKField(appTable) + " = " + appTableId;
- SQLInjectionValidator.validateSQLInput(whereClause);
- sql = sql + "select * from " + sqlGenerator.escape(dataTableName) + " where " + whereClause;
- } else {
- sql = sql + "select * from " + sqlGenerator.escape(dataTableName) + " where id = " + id;
+ String whereClause = getFKField(appTable) + " = " + appTableId;
+ SQLInjectionValidator.validateSQLInput(whereClause);
+ String sql = "select * from " + sqlGenerator.escape(dataTableName) + " where " + whereClause;
+
+ // id only used for reading a specific entry that belongs to appTableId (in a one to many datatable)
+ if (multiRow && id != null) {
+ sql = sql + " and id = " + id;
}
+ LOG.info(sql);
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2354: Fix for reading multirow datatable entry reads non-belonging entry
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2354:
URL: https://github.com/apache/fineract/pull/2354#discussion_r895376399
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1304,18 +1334,19 @@ private GenericResultsetData retrieveDataTableGenericResultSetForUpdate(final St
final List<ResultsetColumnHeaderData> columnHeaders = this.genericDataService.fillResultsetColumnHeaders(dataTableName);
- String sql = "";
+ final boolean multiRow = isMultirowDatatable(columnHeaders);
- // id only used for reading a specific entry in a one to many datatable
- // (when updating)
- if (id == null) {
- String whereClause = getFKField(appTable) + " = " + appTableId;
- SQLInjectionValidator.validateSQLInput(whereClause);
- sql = sql + "select * from " + sqlGenerator.escape(dataTableName) + " where " + whereClause;
- } else {
- sql = sql + "select * from " + sqlGenerator.escape(dataTableName) + " where id = " + id;
+ String whereClause = getFKField(appTable) + " = " + appTableId;
+ SQLInjectionValidator.validateSQLInput(whereClause);
+ String sql = "select * from " + sqlGenerator.escape(dataTableName) + " where " + whereClause;
+
+ // id only used for reading a specific entry that belongs to appTableId (in a one to many datatable)
+ if (multiRow && id != null) {
+ sql = sql + " and id = " + id;
}
+ LOG.info(sql);
Review Comment:
Unnecessary logging here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2354: Fix for reading multirow datatable entry reads non-belonging entry
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2354:
URL: https://github.com/apache/fineract/pull/2354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org