You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/17 06:30:28 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #636: Add `required` job in kvrocks CI for `required_status_checks` configuration
PragmaTwice opened a new pull request, #636:
URL: https://github.com/apache/incubator-kvrocks/pull/636
refer to https://github.com/apache/incubator-kvrocks/pull/635#issuecomment-1158449828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #636: Add `required` job in kvrocks CI for `required_status_checks` configuration
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #636:
URL: https://github.com/apache/incubator-kvrocks/pull/636#discussion_r899845944
##########
.asf.yaml:
##########
@@ -31,6 +31,10 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
required_approving_review_count: 1
+ required_status_checks:
+ strict: true
+ contexts:
+ - "kvrocks ci actions / required (pull_request)"
Review Comment:
done
##########
.github/workflows/kvrocks.yaml:
##########
@@ -96,3 +96,9 @@ jobs:
cd build
cmake ..
make -j4
+
+ required:
+ runs-on: ubuntu-latest
+ needs: [lint-build-test-on-ubuntu, build-on-macos-latest]
+ steps:
+ - run: echo success
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #636: Add `required` job in kvrocks CI for `required_status_checks` configuration
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #636:
URL: https://github.com/apache/incubator-kvrocks/pull/636#discussion_r899827746
##########
.github/workflows/kvrocks.yaml:
##########
@@ -96,3 +96,9 @@ jobs:
cd build
cmake ..
make -j4
+
+ required:
+ runs-on: ubuntu-latest
+ needs: [lint-build-test-on-ubuntu, build-on-macos-latest]
+ steps:
+ - run: echo success
Review Comment:
You may have to check needs.dep in this step. Also you can refer to skywalking's ci yaml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #636: Add `required` job in kvrocks CI for `required_status_checks` configuration
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #636:
URL: https://github.com/apache/incubator-kvrocks/pull/636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #636: Add `required` job in kvrocks CI for `required_status_checks` configuration
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #636:
URL: https://github.com/apache/incubator-kvrocks/pull/636#discussion_r899826764
##########
.asf.yaml:
##########
@@ -31,6 +31,10 @@ github:
required_pull_request_reviews:
dismiss_stale_reviews: false
required_approving_review_count: 1
+ required_status_checks:
+ strict: true
+ contexts:
+ - "kvrocks ci actions / required (pull_request)"
Review Comment:
I think `pull_request` is unneeded. You can refer to https://github.com/apache/skywalking/blob/master/.asf.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org