You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/29 09:27:14 UTC
[GitHub] [apisix] soulbird opened a new issue, #8424: Unified apisix/core/vault.lua and apisix/kms/vault.lua
soulbird opened a new issue, #8424:
URL: https://github.com/apache/apisix/issues/8424
### Description
`apisix/kms/vault.lua` was introduced in https://github.com/apache/apisix/pull/8412.
Functions currently in [apisix/kms/vault.lua](https://github.com/apache/apisix/blob/master/apisix/kms/vault.lua) are copied from [apisix/core/vault.lua](https://github.com/apache/apisix/blob/master/apisix/core/vault.lua).
The functions in `apisix/core/vault.lua` are only used in the `jwt-auth` plugin to save the jwt key, so it is not appropriate to put vault-related functions in the core module. We need to unify them.
The kms component has more comprehensive key management functions and is more versatile, so we should make the following adjustments:
1. Use the vault function provided by the kms component to replace the vault-related functions in the jwt-auth plugin. This will introduce a break change due to changes in configuration.
2. Delete the `apisix/core/vault.lua` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on issue #8424: Unified apisix/core/vault.lua and apisix/secret/vault.lua
Posted by GitBox <gi...@apache.org>.
shreemaan-abhishek commented on issue #8424:
URL: https://github.com/apache/apisix/issues/8424#issuecomment-1378379967
To be noted: `apisix/admin/kms.lua` has been renamed to s`apisix/admin/secrets.lua`. Ref: PR #8448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #8424: Unified apisix/core/vault.lua and apisix/secret/vault.lua
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander closed issue #8424: Unified apisix/core/vault.lua and apisix/secret/vault.lua
URL: https://github.com/apache/apisix/issues/8424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org