You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/27 15:43:33 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request #634: Ballista: Implement scalable distributed joins [DRAFT]
andygrove opened a new pull request #634:
URL: https://github.com/apache/arrow-datafusion/pull/634
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #63.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Ballista cannot scale well without this because work is duplicated across all partitions to load the entire left side of the join into memory currently.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Enable `RepartitionExec` in Ballistra query plans and translate them to shuffles.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Query plans will change.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #634: Ballista: Implement scalable distributed joins
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #634:
URL: https://github.com/apache/arrow-datafusion/pull/634#discussion_r663377702
##########
File path: ballista/rust/core/src/utils.rs
##########
@@ -227,16 +227,7 @@ fn build_exec_plan_diagram(
/// Create a DataFusion context that is compatible with Ballista
pub fn create_datafusion_context() -> ExecutionContext {
- // remove Repartition rule because that isn't supported yet
- let rules: Vec<Arc<dyn PhysicalOptimizerRule + Send + Sync>> = vec![
- Arc::new(CoalesceBatches::new()),
- Arc::new(AddCoalescePartitionsExec::new()),
- ];
- let config = ExecutionConfig::new()
- .with_concurrency(1)
- .with_repartition_joins(false)
- .with_repartition_aggregations(false)
- .with_physical_optimizer_rules(rules);
+ let config = ExecutionConfig::new().with_concurrency(2); // TODO: this is hack to enable partitioned joins
Review comment:
I filed https://github.com/apache/arrow-datafusion/issues/661 to discuss this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #634: Ballista: Implement scalable distributed joins
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #634:
URL: https://github.com/apache/arrow-datafusion/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #634: Ballista: Implement scalable distributed joins
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #634:
URL: https://github.com/apache/arrow-datafusion/pull/634#discussion_r663374937
##########
File path: ballista/rust/core/src/utils.rs
##########
@@ -227,16 +227,7 @@ fn build_exec_plan_diagram(
/// Create a DataFusion context that is compatible with Ballista
pub fn create_datafusion_context() -> ExecutionContext {
- // remove Repartition rule because that isn't supported yet
- let rules: Vec<Arc<dyn PhysicalOptimizerRule + Send + Sync>> = vec![
- Arc::new(CoalesceBatches::new()),
- Arc::new(AddCoalescePartitionsExec::new()),
- ];
- let config = ExecutionConfig::new()
- .with_concurrency(1)
- .with_repartition_joins(false)
- .with_repartition_aggregations(false)
- .with_physical_optimizer_rules(rules);
+ let config = ExecutionConfig::new().with_concurrency(2); // TODO: this is hack to enable partitioned joins
Review comment:
What is the idea here for later? I guess the repartitioning needs to be applied with `concurrency=1` too to avoid inefficient plans?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #634: Ballista: Implement scalable distributed joins
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #634:
URL: https://github.com/apache/arrow-datafusion/pull/634#issuecomment-873410583
@edrevo fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org