You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "slyubomirsky (via GitHub)" <gi...@apache.org> on 2023/05/23 19:20:31 UTC

[GitHub] [tvm] slyubomirsky commented on pull request #14895: [Unity] Allow eliminating only call nodes in CSE pass

slyubomirsky commented on PR #14895:
URL: https://github.com/apache/tvm/pull/14895#issuecomment-1560002887

   The proposed changes are implemented correctly and I don't object to them per se. But I wonder if this is the right solution. Perhaps we should exclude PrimValues from CSE in general instead? There isn't really a good reason to CSE them in the first place. Maybe there are other types of expressions we shouldn't CSE either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org