[GitHub] [superset] rdubois commented on issue #21256: Examples DB is always created, even for a `import-directory` CLI function

[GitBox <gi...@apache.org>]

rdubois commented on issue #21256:
URL: https://github.com/apache/superset/issues/21256#issuecomment-1231680975

   In order to fix that issue, would it be acceptable to make it simple, and add a parameter to the `ImportExamplesCommand`, named `need_examples_database`, `False` by default, and then, conditionally create the database.
   The command would set the boolean to True in the `load_examples_from_configs` method, and keep the default False value in the `load_configs_from_directory` folder ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org