You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/16 12:12:32 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

asdf2014 opened a new pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   Fixes #1257
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041596380


   @kezhenxu94 FYI, https://github.com/apache/incubator-seatunnel/issues/1265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041589046


   Hi @kezhenxu94, thanks for your comment, in this case the job is on pending status, so we still need timeout the step and rerun it, so the `xxx || xxx` solution may not be enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041446414


   May the author can tell us more, cc @nick-invision


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041730493


   > @kezhenxu94 FYI, https://github.com/apache/incubator-seatunnel/issues/1265
   
   From the issue description,
   
   > which is not necessary, maybe we can skip this operation.
   
   Why do you bother to add this retry action instead of resolving that root problem? You are adding a new thing `C` to work around a problem `B`, which should be addressed first. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041448338


   > May the author can tell us more, cc @nick-invision
   
   you can refer this https://infra.apache.org/github-actions-secrets.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041583436


   To retry a command (`xxx`), you can simply use something like `xxx || xxx` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#discussion_r808613413



##########
File path: .github/workflows/backend.yml
##########
@@ -62,15 +62,20 @@ jobs:
         run: |
           ./mvnw -T 2C -B checkstyle:check --no-snapshot-updates
       - name: Build and Package
-        run: |
-          ./mvnw -B install scalastyle:check \
-                 -Dmaven.test.skip=true \
-                 -Dcheckstyle.skip=true \
-                 -Dhttp.keepAlive=false \
-                 -Dmaven.wagon.http.pool=false \
-                 -Dmaven.wagon.http.retryHandler.count=3 \
-                 -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 \
-                 --no-snapshot-updates
+        uses: nick-invision/retry@v2
+        with:
+          timeout_minutes: 10

Review comment:
       @leo65535 It is enough for this step




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041589705


   > To retry a command (`xxx`), you can simply use something like `xxx || xxx`
   
   If you insist using that GitHub Action, you need to add it as sub module or request the infra team to add it into allowlist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1042500625


   Closing in favor of https://github.com/apache/incubator-seatunnel/pull/1266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041580898


   > May the author can tell us more, cc @nick-invision
   
   No need to mention people unless you are very certain otherwise it's kind of disturbing, according to ASF policy, third-party GitHub actions can not be executed in ASF repos unless they are allowlisted. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041451129


   Hi @CalvinKirs, thanks for your comments, it seems that I don't have permission to access the secrets of this project :sweat_smile:
   
   ![image](https://user-images.githubusercontent.com/8108788/154266075-0a0b60dd-a5c5-480b-a384-179bd4f5595f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#discussion_r808593401



##########
File path: .github/workflows/backend.yml
##########
@@ -62,15 +62,20 @@ jobs:
         run: |
           ./mvnw -T 2C -B checkstyle:check --no-snapshot-updates
       - name: Build and Package
-        run: |
-          ./mvnw -B install scalastyle:check \
-                 -Dmaven.test.skip=true \
-                 -Dcheckstyle.skip=true \
-                 -Dhttp.keepAlive=false \
-                 -Dmaven.wagon.http.pool=false \
-                 -Dmaven.wagon.http.retryHandler.count=3 \
-                 -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 \
-                 --no-snapshot-updates
+        uses: nick-invision/retry@v2
+        with:
+          timeout_minutes: 10

Review comment:
       hi @asdf2014, `timeout_minutes: 10` may is not enough, seems most actions always beyond the limits.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041591365


   > Hi @kezhenxu94, thanks for your comment, in this case the job is on pending status, so we still need timeout the step and rerun it, so the `xxx || xxx` solution may not be enough.
   
   I rarely see maven command itself can get stuck and timeout, can you give me an example case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041619385


   Hi @kezhenxu94, thanks for your suggestion, I just raised up a ticket to the Infra team, let's put eyes on it, FYI, https://issues.apache.org/jira/browse/INFRA-22891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258#issuecomment-1041749897


   @kezhenxu94 Indeed, this is a work around solution, if my another solution https://github.com/apache/incubator-seatunnel/pull/1266 is working, I may close this one in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 closed pull request #1258: [Feature][ci] Rerun failed step for the backend Github action

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed pull request #1258:
URL: https://github.com/apache/incubator-seatunnel/pull/1258


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org