You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/05/29 10:43:10 UTC
[GitHub] brooklyn-server pull request #705: jclouds stub test: better allow config to...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/705
jclouds stub test: better allow config to be overridden
This allows sub-classes to better override the config values
(the `jcloudsLocationConfig` can contain keys of type ConfigKey or String).
Also fixes the log.debug, to say what the default value is overridden with.
The motivator for this change is my use of it in a downstream project, which failed because the overrides weren't being applied (when passed in as string keys).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix-stubbedJcloudsTest-config-overriding
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #705
----
commit b845e41c695175bcf8c8fd5660df0e2a64978146
Author: Aled Sage <al...@gmail.com>
Date: 2017-05-29T10:41:32Z
jclouds stub test: better allow config to be overridden
This allows sub-classes to better override the config values
(the `jcloudsLocationConfig` can contain keys of type ConfigKey or
String).
Also fixes the log.debug, to say what the default value is overridden
with.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #705: jclouds stub test: better allow config to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/705
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #705: jclouds stub test: better allow config to be ove...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/705
jenkins build passed (see https://builds.apache.org/job/brooklyn-server-pull-requests/2173). Not sure why it's not updating the PR (to say that the PR was being built, or with the result).
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---