[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3739: [WIP] Support materialized view schema change

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r436373392



##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1425,15 +1514,17 @@ OLAPStatus SchemaChangeHandler::schema_version_convert(
 
     // a. 解析Alter请求，转换成内部的表示形式
     // 不使用DELETE_DATA命令指定的删除条件
-    RowBlockChanger rb_changer(new_tablet->tablet_schema(), base_tablet);
+    RowBlockChanger rb_changer(new_tablet->tablet_schema());
     bool sc_sorting = false;
     bool sc_directly = false;
 
+    const std::map<std::string, AlterMaterializedViewParam> materialized_function_map;

Review comment:
       unorder_map is enough？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org