[jira] [Commented] (YETUS-499) github pull requests not ending in patch are not found in Jira bug systems

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014722#comment-16014722 ] 

Allen Wittenauer commented on YETUS-499:
----------------------------------------

Sorry, this fell through the cracks.

The JIRA-github hooks were built with the asfgit handling in mind.  The reason why .patch is used is because of how asfgit adds comments to a JIRA.  For example, take a look at TINKERPOP-1653 or any number of other asfgit-handled issues.  

I'm concerned that not looking specifically for .patch will cause a tremendous amount of extra work for Jenkins, since asfgit also puts links to the pull request for every comment and action on the PR.  

Another thing to consider is how Atlassian's SaaS JIRA intergrate with github.  I believe it is different yet.

That said: YETUS-315 isn't using asfgit.  So it isn't surprising that it wasn't picked up.

> github pull requests not ending in patch are not found in Jira bug systems
> --------------------------------------------------------------------------
>
>                 Key: YETUS-499
>                 URL: https://issues.apache.org/jira/browse/YETUS-499
>             Project: Yetus
>          Issue Type: Bug
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>            Priority: Minor
>         Attachments: YETUS-499.00.patch, YETUS-499.01.patch
>
>
> For example:
> YETUS-315 contains a pull request not ending in a patch.
> Performing:
> {code}
> ./precommit/test-patch.sh --plugins=all YETUS-315 
> {code}
> determines correctly that YETUS-315 isn't a pull request, 
> correctly contacts the Jira system, downloads the Jira text, and
> then looks for a file starting in GITHUB_BASE_URL and ending in "patch"
> this is not found, because the link attached is a pull link ending with a number.
> This could be improved.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)