[jira] Commented: (DERBY-3227) Remove final from all getConnection() methods in EmbeddedDataSource

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545460 ] 

Knut Anders Hatlen commented on DERBY-3227:
-------------------------------------------

I'm not sure it's a good idea to let applications rely on the ability to extend Derby's classes and override their methods. Would it be possible to work around this issue by writing a custom DataSource class that contains a reference to an EmbeddedDataSource to which it forwards all method calls?

> Remove final from all getConnection() methods in EmbeddedDataSource
> -------------------------------------------------------------------
>
>                 Key: DERBY-3227
>                 URL: https://issues.apache.org/jira/browse/DERBY-3227
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.3.1.4
>            Reporter: Aaron Digulla
>            Priority: Minor
>
> The final modifier makes it impossible to wrap Derby connections in P6Spy, for example.
> The network ClientDataSource doesn't use final, either.
> Patch: Replace "public final Connection" with "public Connection" two times.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.