You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/01 03:12:45 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #13377: refactor(explore): restructure DateFilterControl
zhaoyongjie opened a new pull request #13377:
URL: https://github.com/apache/superset/pull/13377
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- move `utils.ts` and `constants.ts` to `DateFilterControl.utils`
- rename `DateFilterControl.frame` to `DateFilterControl.components`
- move original `DateFilterControl` to `LegacyDateFilterControl`
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
changed files/packages structure only.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787622732
# [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=h1) Report
> Merging [#13377](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=desc) (2ca8747) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.33%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13377 +/- ##
==========================================
- Coverage 77.09% 72.76% -4.34%
==========================================
Files 898 599 -299
Lines 45711 21262 -24449
Branches 5495 5497 +2
==========================================
- Hits 35241 15471 -19770
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <100.00%> (+0.28%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.58% <71.42%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <ø> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/components/index.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <ø> (ø)` | |
| [...rols/LegacyDateFilterControl/DateFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9MZWdhY3lEYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `85.84% <100.00%> (ø)` | |
| ... and [309 more](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=footer). Last update [3c62069...024cd54](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787991376
> Here's FilterBox with the old component:
> 
> Here with the new one (probably needs a slight CSS tweak):
> 
> Also, should we just remove the old `LegacyDateFilterControl`, as I don't think it's really needed anymore after this?
OH, thanks Ville, good catch. I will check this issue.
I very much agree to remove the old components, but I am afraid whether there are other companies that still rely on the original components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #13377: feat(viz): implement time picker on filter box
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #13377:
URL: https://github.com/apache/superset/pull/13377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-788036643
> > I very much agree to remove the old components, but I am afraid whether there are other companies that still rely on the original components.
>
> I think it's ok to remove it, as I feel we've made a collective decision to replace the old time picker with the new one. Anyway, if someone really needs it they can go to a previous SHA and get the code from there 🙂
OK. I remove these legacy codes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787622732
# [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=h1) Report
> Merging [#13377](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=desc) (4515922) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.33%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13377 +/- ##
==========================================
- Coverage 77.09% 72.76% -4.34%
==========================================
Files 898 599 -299
Lines 45711 21262 -24449
Branches 5495 5497 +2
==========================================
- Hits 35241 15471 -19770
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <100.00%> (+0.28%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.58% <71.42%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <ø> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/components/index.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <ø> (ø)` | |
| [...rols/LegacyDateFilterControl/DateFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9MZWdhY3lEYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `85.84% <100.00%> (ø)` | |
| ... and [309 more](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=footer). Last update [3c62069...4515922](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-788069712
@villebro, I fixed the style issue.
<img width="1418" alt="image" src="https://user-images.githubusercontent.com/2016594/109524375-68422280-7aeb-11eb-9fdb-5a1583f1eb34.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-788069712
@villebro fixed the style issue.
<img width="1418" alt="image" src="https://user-images.githubusercontent.com/2016594/109524375-68422280-7aeb-11eb-9fdb-5a1583f1eb34.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-788031070
> I very much agree to remove the old components, but I am afraid whether there are other companies that still rely on the original components.
I think it's ok to remove it, as I feel we've made a collective decision to replace the old time picker with the new one. Anyway, if someone really needs it they can go to a previous SHA and get the code from there 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787622732
# [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=h1) Report
> Merging [#13377](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=desc) (bb56099) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.19%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13377 +/- ##
==========================================
- Coverage 77.09% 72.90% -4.20%
==========================================
Files 898 598 -300
Lines 45711 21088 -24623
Branches 5495 5386 -109
==========================================
- Hits 35241 15374 -19867
+ Misses 10344 5588 -4756
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <100.00%> (+0.28%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.63% <71.42%> (+0.05%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <ø> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/components/index.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <ø> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `85.84% <100.00%> (ø)` | |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `84.61% <100.00%> (ø)` | |
| ... and [307 more](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=footer). Last update [3c62069...b88326b](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787622732
# [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=h1) Report
> Merging [#13377](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=desc) (2ca8747) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.33%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13377 +/- ##
==========================================
- Coverage 77.09% 72.76% -4.34%
==========================================
Files 898 599 -299
Lines 45711 21262 -24449
Branches 5495 5497 +2
==========================================
- Hits 35241 15471 -19770
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <100.00%> (+0.28%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.58% <71.42%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <ø> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/components/index.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <ø> (ø)` | |
| [...rols/LegacyDateFilterControl/DateFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9MZWdhY3lEYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `85.84% <100.00%> (ø)` | |
| ... and [309 more](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=footer). Last update [3c62069...19b381b](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787622732
# [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=h1) Report
> Merging [#13377](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=desc) (4515922) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.33%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13377 +/- ##
==========================================
- Coverage 77.09% 72.76% -4.34%
==========================================
Files 898 599 -299
Lines 45711 21262 -24449
Branches 5495 5497 +2
==========================================
- Hits 35241 15471 -19770
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <100.00%> (+0.28%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.58% <71.42%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <ø> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/components/index.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <ø> (ø)` | |
| [...rols/LegacyDateFilterControl/DateFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9MZWdhY3lEYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `85.84% <100.00%> (ø)` | |
| ... and [309 more](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=footer). Last update [3c62069...19b381b](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13377: feat(viz): implement time picker on filter box
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-788407902
Thank you @villebro.
I totally agree with your suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13377: refactor(explore): restructure DateFilterControl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13377:
URL: https://github.com/apache/superset/pull/13377#issuecomment-787622732
# [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=h1) Report
> Merging [#13377](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=desc) (2ca8747) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.33%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13377 +/- ##
==========================================
- Coverage 77.09% 72.76% -4.34%
==========================================
Files 898 599 -299
Lines 45711 21262 -24449
Branches 5495 5497 +2
==========================================
- Hits 35241 15471 -19770
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <100.00%> (+0.28%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.58% <71.42%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <ø> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/components/index.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ents/controls/DateFilterControl/utils/constants.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <ø> (ø)` | |
| [...rols/LegacyDateFilterControl/DateFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9MZWdhY3lEYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `85.84% <100.00%> (ø)` | |
| ... and [309 more](https://codecov.io/gh/apache/superset/pull/13377/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=footer). Last update [3c62069...b88326b](https://codecov.io/gh/apache/superset/pull/13377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org