You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/01 06:19:30 UTC

[GitHub] [spark] itholic opened a new pull request #32728: [SPARK-35582][PYTHON][DOCS] Remove # noqa in Python API documents.

itholic opened a new pull request #32728:
URL: https://github.com/apache/spark/pull/32728


   ### What changes were proposed in this pull request?
   
   This PR aims to move `# noqa` in the Python docstring to the proper place so that hide them from the official documents.
   
   
   ### Why are the changes needed?
   
   If we don't move `# noqa` to the proper place, it is exposed in the middle of the docstring, and it looks a bit wired as below:
   <img width="613" alt="Screen Shot 2021-06-01 at 3 17 52 PM" src="https://user-images.githubusercontent.com/44108233/120275617-91da3800-c2ec-11eb-9778-16c5fe789418.png">
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, the `# noqa` doesn't show in the documents anymore.
   
   
   ### How was this patch tested?
   
   Manually build docs and check.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] itholic commented on pull request #32728: [SPARK-35582][PYTHON][DOCS] Remove # noqa in Python API documents.

Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #32728:
URL: https://github.com/apache/spark/pull/32728#issuecomment-851852612


   There is only one case remaining in the `schema_of_json` since other cases are all resolved in the previous PR.
   
   Please refer to: https://github.com/apache/spark/pull/32658/commits/3bda8db8e50d6550089b1cb1770d6cfe078bcaf8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32728: [SPARK-35582][PYTHON][DOCS] Remove # noqa in Python API documents.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32728:
URL: https://github.com/apache/spark/pull/32728#issuecomment-851854693


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #32728: [SPARK-35582][PYTHON][DOCS] Remove # noqa in Python API documents.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32728:
URL: https://github.com/apache/spark/pull/32728


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org