You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/15 00:36:43 UTC
[GitHub] [cordova-android] 8bhsolutions opened a new pull request #1091: Fix for #924 - Concurrent Modification Exception
8bhsolutions opened a new pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091
Fix for #924
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
ConcurrentModificationException occurs when starting app, and sometimes randomly in app usage
### Description
<!-- Describe your changes in detail -->
Use `Collection.synchronizedMap` and ensure all access is sync by wrap all usage of the collection with `synchronized` keyword
### Testing
<!-- Please describe in detail how you tested your changes. -->
Used for a few months in production now without any issues
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1091: fix: Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091#issuecomment-808748103
Thank you for your contribution @ebhsgit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek closed pull request #1091: Fix for #924 - Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1091: Fix for #924 - Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091#issuecomment-708772678
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=h1) Report
> Merging [#1091](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 69.71% 69.65% -0.06%
==========================================
Files 20 20
Lines 1806 1806
==========================================
- Hits 1259 1258 -1
- Misses 547 548 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1091/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=footer). Last update [3b56160...48dad95](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1091: Fix for #924 - Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091#issuecomment-708772678
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=h1) Report
> Merging [#1091](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1091 +/- ##
=======================================
Coverage 69.71% 69.71%
=======================================
Files 20 20
Lines 1806 1806
=======================================
Hits 1259 1259
Misses 547 547
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=footer). Last update [3b56160...48dad95](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1091: Fix for #924 - Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091#issuecomment-708772678
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=h1) Report
> Merging [#1091](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
+ Coverage 69.71% 69.76% +0.05%
==========================================
Files 20 20
Lines 1806 1806
==========================================
+ Hits 1259 1260 +1
+ Misses 547 546 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1091/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `59.43% <0.00%> (+0.47%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=footer). Last update [3b56160...48dad95](https://codecov.io/gh/apache/cordova-android/pull/1091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1091: Fix for #924 - Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091#issuecomment-708772678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1091: fix: Concurrent Modification Exception
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1091:
URL: https://github.com/apache/cordova-android/pull/1091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org