You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Dave Newton (JIRA)" <ji...@apache.org> on 2008/12/01 18:10:37 UTC
[jira] Created: (WW-2901) Set the default includeParams to "none"
(is currently "get")
Set the default includeParams to "none" (is currently "get")
------------------------------------------------------------
Key: WW-2901
URL: https://issues.apache.org/struts/browse/WW-2901
Project: Struts 2
Issue Type: Improvement
Affects Versions: 2.1.3
Reporter: Dave Newton
Assignee: Dave Newton
Fix For: 2.1.3
(This is off the top of my head; will add comment when checked in.)
- Includes a test fix (I don't like that test code, but hey) for number of things set in the test config file (I have locally).
- Breaks backwards compatibility (if anybody actually relies on this, which seems improbable).
- Adding to
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2901) Set the default includeParams to "none"
(is currently "get")
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45086#action_45086 ]
Dave Newton commented on WW-2901:
---------------------------------
Not included in the patch is the change to the URL component's @StrutsTagAttribute documentation.
I don't like the lack of cohesion created by manually specifying configuration file values :(
> Set the default includeParams to "none" (is currently "get")
> ------------------------------------------------------------
>
> Key: WW-2901
> URL: https://issues.apache.org/struts/browse/WW-2901
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Dave Newton
> Assignee: Dave Newton
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: params-patch.diff
>
>
> (This is off the top of my head; will add comment when checked in.)
> - Includes a test fix (I don't like that test code, but hey) for number of things set in the test config file (I have locally).
> - Breaks backwards compatibility (if anybody actually relies on this, which seems improbable).
> - Adding to
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2901) Set the default includeParams to "none"
(is currently "get")
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Newton resolved WW-2901.
-----------------------------
Resolution: Implemented
This change may introduce backwards incompatibility in existing applications.
This change makes the default struts.url.includeParams = none; it was "get" before.
Applications that use the <s:url...> tag that relied on the default being "get" will need to be updated by either (a) setting the default value to "get" or (b) modifying tag usage to use the "includeParams" attribute, setting it to "get".
> Set the default includeParams to "none" (is currently "get")
> ------------------------------------------------------------
>
> Key: WW-2901
> URL: https://issues.apache.org/struts/browse/WW-2901
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Dave Newton
> Assignee: Dave Newton
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: params-patch.diff
>
>
> (This is off the top of my head; will add comment when checked in.)
> - Includes a test fix (I don't like that test code, but hey) for number of things set in the test config file (I have locally).
> - Breaks backwards compatibility (if anybody actually relies on this, which seems improbable).
> - Adding to
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2901) Set the default includeParams to "none"
(is currently "get")
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Newton updated WW-2901:
----------------------------
Attachment: params-patch.diff
This is the patch I applied.
> Set the default includeParams to "none" (is currently "get")
> ------------------------------------------------------------
>
> Key: WW-2901
> URL: https://issues.apache.org/struts/browse/WW-2901
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Dave Newton
> Assignee: Dave Newton
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: params-patch.diff
>
>
> (This is off the top of my head; will add comment when checked in.)
> - Includes a test fix (I don't like that test code, but hey) for number of things set in the test config file (I have locally).
> - Breaks backwards compatibility (if anybody actually relies on this, which seems improbable).
> - Adding to
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2901) Set the default includeParams to "none"
(is currently "get")
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Newton updated WW-2901:
----------------------------
Priority: Minor (was: Major)
> Set the default includeParams to "none" (is currently "get")
> ------------------------------------------------------------
>
> Key: WW-2901
> URL: https://issues.apache.org/struts/browse/WW-2901
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Dave Newton
> Assignee: Dave Newton
> Priority: Minor
> Fix For: 2.1.3
>
>
> (This is off the top of my head; will add comment when checked in.)
> - Includes a test fix (I don't like that test code, but hey) for number of things set in the test config file (I have locally).
> - Breaks backwards compatibility (if anybody actually relies on this, which seems improbable).
> - Adding to
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2901) Set the default
includeParams to "none" (is currently "get")
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45086#action_45086 ]
newton_dave edited comment on WW-2901 at 12/1/08 6:06 PM:
----------------------------------------------------------
Not included in the patch is the change to the URL component's @StrutsTagAttribute documentation.
I don't like the lack of cohesion created by manually documenting configuration file values; it was chance that I saw the <s:url...> tag documentation and realized it would have to be updated.
was (Author: newton_dave):
Not included in the patch is the change to the URL component's @StrutsTagAttribute documentation.
I don't like the lack of cohesion created by manually specifying configuration file values :(
> Set the default includeParams to "none" (is currently "get")
> ------------------------------------------------------------
>
> Key: WW-2901
> URL: https://issues.apache.org/struts/browse/WW-2901
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Dave Newton
> Assignee: Dave Newton
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: params-patch.diff
>
>
> (This is off the top of my head; will add comment when checked in.)
> - Includes a test fix (I don't like that test code, but hey) for number of things set in the test config file (I have locally).
> - Breaks backwards compatibility (if anybody actually relies on this, which seems improbable).
> - Adding to
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.