You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/08/18 18:27:43 UTC
[kudu-CR] [java] Include spark/scala base version in spark-tools
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7723
Change subject: [java] Include spark/scala base version in spark-tools
......................................................................
[java] Include spark/scala base version in spark-tools
Renames the kudu-spark-tools artifact to include the
spark and scala base version. Including the scala
version is standard practice and help users avoid binary
compatability issues. Adding the Spark base version matches
the pattern used in the kudu-spark module and prevents users
from trying to use kudu-spark-tools with Spark 1. This change
will also make upgrades to Scala 2.12 or Spark 3 in the future
more seamless.
Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Before: kudu-spark-tools
After: kudu-spark2-tools_2.11
---
M docs/release_notes.adoc
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
3 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/7723/1
--
To view, visit http://gerrit.cloudera.org:8080/7723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [java] Include Spark/Scala base version in kudu-spark-tools
......................................................................
[java] Include Spark/Scala base version in kudu-spark-tools
Renames the kudu-spark-tools artifact to include the
spark and scala base version. Including the scala
version is standard practice and helps users avoid binary
compatability issues. Adding the Spark base version matches
the pattern used in the kudu-spark module and prevents users
from trying to use kudu-spark-tools with Spark 1. This change
will also make upgrades to Scala 2.12 or Spark 3 in the future
more seamless.
Before: kudu-spark-tools
After: kudu-spark2-tools_2.11
Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Reviewed-on: http://gerrit.cloudera.org:8080/7723
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M docs/release_notes.adoc
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
3 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] Include Spark/Scala base version in kudu-spark-tools
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#2).
Change subject: [java] Include Spark/Scala base version in kudu-spark-tools
......................................................................
[java] Include Spark/Scala base version in kudu-spark-tools
Renames the kudu-spark-tools artifact to include the
spark and scala base version. Including the scala
version is standard practice and helps users avoid binary
compatability issues. Adding the Spark base version matches
the pattern used in the kudu-spark module and prevents users
from trying to use kudu-spark-tools with Spark 1. This change
will also make upgrades to Scala 2.12 or Spark 3 in the future
more seamless.
Before: kudu-spark-tools
After: kudu-spark2-tools_2.11
Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
---
M docs/release_notes.adoc
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
3 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/7723/2
--
To view, visit http://gerrit.cloudera.org:8080/7723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java] Include Spark/Scala base version in kudu-spark-tools
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e25b0a0d560d5c9504002fbe3bbcfdc79a83d2d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No