You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/13 13:54:02 UTC
[GitHub] [incubator-dolphinscheduler] liwenhe1993 opened a new pull request
#1952: Add unit test
liwenhe1993 opened a new pull request #1952: Add unit test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952
Add unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1952: Add unit test
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1952: Add unit test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952#issuecomment-585769055
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1952&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='3.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1952&metric=new_coverage&view=list) [3.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1952&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1952&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1952&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] liwenhe1993 closed pull request #1952:
Add unit test
Posted by GitBox <gi...@apache.org>.
liwenhe1993 closed pull request #1952: Add unit test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1952:
Add unit test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1952: Add unit test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952#issuecomment-585767386
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=h1) Report
> Merging [#1952](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/86e607dc564e9a4819dfc469626f196127db8622?src=pr&el=desc) will **increase** coverage by `6.89%`.
> The diff coverage is `47.52%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1952 +/- ##
============================================
+ Coverage 20.22% 27.11% +6.89%
- Complexity 0 1383 +1383
============================================
Files 290 312 +22
Lines 14082 16680 +2598
Branches 2376 2056 -320
============================================
+ Hits 2848 4523 +1675
- Misses 10908 11679 +771
- Partials 326 478 +152
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inscheduler/server/master/config/MasterConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25maWcvTWFzdGVyQ29uZmlnLmphdmE=) | `18.18% <ø> (ø)` | `3 <0> (?)` | |
| [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `17.03% <ø> (+17.03%)` | `8 <0> (+8)` | :arrow_up: |
| [...nscheduler/dao/quartz/DruidConnectionProvider.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3F1YXJ0ei9EcnVpZENvbm5lY3Rpb25Qcm92aWRlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...hinscheduler/api/controller/ProjectController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvamVjdENvbnRyb2xsZXIuamF2YQ==) | `3.44% <ø> (+3.44%)` | `2 <0> (+2)` | :arrow_up: |
| [...duler/server/worker/task/ShellCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1NoZWxsQ29tbWFuZEV4ZWN1dG9yLmphdmE=) | `85% <ø> (+85%)` | `4 <0> (+4)` | :arrow_up: |
| [...che/dolphinscheduler/dao/entity/ResourcesUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZXNVc2VyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dolphinscheduler/dao/entity/ProjectUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0VXNlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/dao/quartz/QuartzExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3F1YXJ0ei9RdWFydHpFeGVjdXRvcnMuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...che/dolphinscheduler/common/log/TaskLogFilter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9UYXNrTG9nRmlsdGVyLmphdmE=) | `33.33% <ø> (ø)` | `2 <0> (?)` | |
| [...e/dolphinscheduler/common/log/WorkerLogFilter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9Xb3JrZXJMb2dGaWx0ZXIuamF2YQ==) | `33.33% <ø> (ø)` | `2 <0> (?)` | |
| ... and [375 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=footer). Last update [86e607d...5ccebbf](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services