You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/09 22:31:37 UTC
Re: Review Request 70956: Modified registry operations for unreachable
draining agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70956/#review216457
-----------------------------------------------------------
Ship it!
- Greg Mann
On June 26, 2019, 8:45 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70956/
> -----------------------------------------------------------
>
> (Updated June 26, 2019, 8:45 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When agents transition from reachable to unreachable, or vice
> versa, the draining config is now copied too, along with the
> 'deactivated' boolean.
>
>
> Diffs
> -----
>
> src/master/registry.proto 67904edf73235a4007f7c59c05dc4f1abab1cd08
> src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
> src/tests/registrar_tests.cpp 5f0de523705d124ddd2d21ad355f06633d68c141
>
>
> Diff: https://reviews.apache.org/r/70956/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>