You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/01 22:54:57 UTC
[GitHub] [incubator-superset] adam-stasiak opened a new pull request #11134: [WIP] chore: Cypress all selectors refactor
adam-stasiak opened a new pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501299963
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -293,7 +293,10 @@ function DashboardList(props: DashboardListProps) {
className="action-button"
onClick={confirmDelete}
>
- <Icon name="trash" />
+ <Icon
+ {...{ 'data-test': 'dashboard-list-trash-icon' }}
Review comment:
Wondering again about the need spread syntax over the attribute, which could be stripped out by babel for sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501296216
##########
File path: superset-frontend/src/explore/components/ExploreChartHeader.jsx
##########
@@ -131,7 +131,11 @@ export class ExploreChartHeader extends React.PureComponent {
this.props.chart.chartStatus,
);
return (
- <StyledHeader id="slice-header" className="clearfix panel-title-large">
+ <StyledHeader
+ id="slice-header"
+ className="clearfix panel-title-large"
+ ref
Review comment:
Why the 'ref' prop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-709471608
@adam-stasiak should this PR be closed in favor of the newer ones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-703589673
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6358a7f1b552dd158fa88fd0f3556b8df4193ff1?el=desc) will **decrease** coverage by `4.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.88% 61.33% -4.55%
==========================================
Files 827 391 -436
Lines 39046 24483 -14563
Branches 3673 0 -3673
==========================================
- Hits 25725 15017 -10708
+ Misses 13214 9466 -3748
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.33% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | | |
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | | |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | | |
| [superset-frontend/src/addSlice/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL2luZGV4LnRzeA==) | | |
| [superset-frontend/src/logger/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4Lmpz) | | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [superset-frontend/src/utils/errorMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Vycm9yTWVzc2FnZXMuanM=) | | |
| ... and [377 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [6358a7f...f5bbf61](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r500761039
##########
File path: superset-frontend/src/components/ListView/TableCollection.tsx
##########
@@ -260,6 +264,7 @@ export default function TableCollection({
prepareRow(row);
return (
<tr
+ data-test="table-row"
Review comment:
I am a bit nervous about cases like this where we're adding a bunch of HTML markup for ever row and cell. If we strip these data-test attributes out for production builds, then I'm not worried about it.
In any case, I _love_ the changes in this PR where the data-test attribute points at a _specific instance_ of something, making the test more traceable/fixable, but I'm wondering if examples like this are adding much value, since the data-test attribute is just a twin of the class. I guess it doesn't hurt, and separates the concerns, so the class (for styling) can be safely changed/renamed/removed/conditional.
I guess it's fine, just a little concerned about the value-to-markup ratio. If we strip out the markup for prod, it's not a problem to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501299027
##########
File path: superset-frontend/src/explore/components/controls/DateFilterControl.jsx
##########
@@ -523,9 +523,10 @@ class DateFilterControl extends React.Component {
this.startEndSectionRef = ref;
}}
>
- <InputGroup>
+ <InputGroup data-test="date-input-group">
<div style={{ margin: '5px 0' }}>
<Datetime
+ inputProps={{ 'data-test': 'date-from-input' }}
Review comment:
Hmm... I wonder if that babel extension will manage strip out data-test attributes added like this. ¯\\\_(ツ)_/¯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r500762973
##########
File path: superset-frontend/src/common/components/Modal.tsx
##########
@@ -78,11 +78,6 @@ const StyledModal = styled(BaseModal)`
margin-left: 8px;
}
}
-
- // styling for Tabs component
Review comment:
It looks like a rebasing mistake to me. Adam, can you please bring it back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-703927214
@rusackas do you have any suggestions here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r500756292
##########
File path: superset-frontend/src/common/components/Modal.tsx
##########
@@ -78,11 +78,6 @@ const StyledModal = styled(BaseModal)`
margin-left: 8px;
}
}
-
- // styling for Tabs component
Review comment:
Curious if/how this is relevant to the PR... looks like it would be a visual change... is it something @kgabryje is aware of?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `5.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.07% -5.54%
==========================================
Files 832 394 -438
Lines 39400 24716 -14684
Branches 3593 0 -3593
==========================================
- Hits 25849 14848 -11001
+ Misses 13442 9868 -3574
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.07% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...7dc243e](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-705086783
> > @adam-stasiak this PR is huge and hard to review. Could you break this down into multiple smaller PRs?
>
> I'm just slogging through it, a few files here and a few files there, making comments as I go. Looks like it needs a rebase currently, but I'll keep revisiting, and we can just shove it across the line.
How would you split this? I would vote for PR for TSX changes and then PRs for cypress modules?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.77% -4.84%
==========================================
Files 832 394 -438
Lines 39400 24716 -14684
Branches 3593 0 -3593
==========================================
- Hits 25849 15021 -10828
+ Misses 13442 9695 -3747
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.77% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | | |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| [...board/components/gridComponents/new/NewDivider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEaXZpZGVyLmpzeA==) | | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | | |
| ... and [382 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...dae02cb](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.77% -4.84%
==========================================
Files 832 394 -438
Lines 39400 24716 -14684
Branches 3593 0 -3593
==========================================
- Hits 25849 15021 -10828
+ Misses 13442 9695 -3747
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.77% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | | |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5bGlzdGVuZXJzLmpzeA==) | | |
| [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | | |
| [superset-frontend/src/showSavedQuery/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L3V0aWxzLmpz) | | |
| [...rc/dashboard/components/FilterIndicatorTooltip.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvclRvb2x0aXAuanN4) | | |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
| ... and [382 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...dae02cb](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501297231
##########
File path: superset-frontend/src/explore/components/PropertiesModal.tsx
##########
@@ -159,7 +159,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
return (
<form onSubmit={onSubmit}>
- <Modal.Header closeButton>
+ <Modal.Header data-test="edit-modal" closeButton>
Review comment:
Could be more specific (i.e. 'edit-properties-modal') if you can expect there to be more than one instance of modal in the code with `data-test="edit-modal"` - it just makes it easier to find the instance in the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `5.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.08% -5.52%
==========================================
Files 832 394 -438
Lines 39400 24705 -14695
Branches 3593 0 -3593
==========================================
- Hits 25849 14845 -11004
+ Misses 13442 9860 -3582
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.08% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...7dc243e](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r500763584
##########
File path: superset-frontend/src/components/ListView/TableCollection.tsx
##########
@@ -260,6 +264,7 @@ export default function TableCollection({
prepareRow(row);
return (
<tr
+ data-test="table-row"
Review comment:
I think we could tackle it with a babel plugin such as this one: https://www.npmjs.com/package/babel-plugin-jsx-remove-data-test-id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501285631
##########
File path: superset-frontend/src/dashboard/components/IconButton.jsx
##########
@@ -50,8 +50,9 @@ export default class IconButton extends React.PureComponent {
onClick={this.handleClick}
tabIndex="0"
role="button"
+ data-test="icon-button"
>
- <span className={className} />
+ <span {...{ 'data-test': 'icon-button-span' }} className={className} />
Review comment:
Curious why the spread syntax here instead of the usual attribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-705085187
> @adam-stasiak this PR is huge and hard to review. Could you break this down into multiple smaller PRs?
I'm just slogging through it, a few files here and a few files there, making comments as I go. Looks like it needs a rebase currently, but I'll keep revisiting, and we can just shove it across the line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501300129
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -432,7 +435,11 @@ function DashboardList(props: DashboardListProps) {
className="action-button"
onClick={confirmDelete}
>
- <ListViewCard.MenuIcon name="trash" /> Delete
+ <ListViewCard.MenuIcon
+ {...{ 'data-test': 'dashboard-card-view-trash-icon' }}
Review comment:
same spread question here :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r501186089
##########
File path: superset-frontend/src/components/ListView/TableCollection.tsx
##########
@@ -260,6 +264,7 @@ export default function TableCollection({
prepareRow(row);
return (
<tr
+ data-test="table-row"
Review comment:
This babel plugin is a good next step I think with tests. I will put this on my list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-703926683
@willbarrett I did this big PR because my partials were outdated and it was hard to rebase them when I was adding module by module.
I can split this by Cypress module fraction so split into PR for Dashboard, PR for Explore module, but I am afraid it would be hard to seperate changes in components. Is it ok to just make this smaller with cypress part not TSX?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r500761795
##########
File path: superset-frontend/src/components/ListView/TableCollection.tsx
##########
@@ -271,15 +276,16 @@ export default function TableCollection({
const columnCellProps = cell.column.cellProps || {};
return (
<td
- className={cx('table-cell', {
+ data-test="row-cell"
+ className={cx('row-cell', {
Review comment:
The `table-cell` class removed here appears to have CSS styles that were applied to it. Is there a reason to cahge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `5.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.57% -5.04%
==========================================
Files 832 394 -438
Lines 39400 24716 -14684
Branches 3593 0 -3593
==========================================
- Hits 25849 14971 -10878
+ Misses 13442 9745 -3697
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.57% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.06% <0.00%> (-0.68%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...7dc243e](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-703589673
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6358a7f1b552dd158fa88fd0f3556b8df4193ff1?el=desc) will **decrease** coverage by `4.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.88% 61.33% -4.55%
==========================================
Files 827 391 -436
Lines 39046 24483 -14563
Branches 3673 0 -3673
==========================================
- Hits 25725 15017 -10708
+ Misses 13214 9466 -3748
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.33% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/components/Pagination.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi50c3g=) | | |
| [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | | |
| [superset-frontend/src/visualizations/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2NvbnN0YW50cy5qcw==) | | |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | | |
| [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0QW5kTGFiZWxDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | | |
| ... and [377 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [6358a7f...f5bbf61](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-703925019
@adam-stasiak this PR is huge and hard to review. Could you break this down into multiple smaller PRs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `5.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.06% -5.55%
==========================================
Files 832 394 -438
Lines 39400 24705 -14695
Branches 3593 0 -3593
==========================================
- Hits 25849 14838 -11011
+ Misses 13442 9867 -3575
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.06% <ø> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...7dc243e](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.77% -4.84%
==========================================
Files 832 394 -438
Lines 39400 24716 -14684
Branches 3593 0 -3593
==========================================
- Hits 25849 15020 -10829
+ Misses 13442 9696 -3746
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.77% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | | |
| ... and [383 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...dae02cb](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#discussion_r500749777
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/pivot_table.test.js
##########
@@ -66,42 +66,70 @@ describe('Visualization > Pivot Table', () => {
it('should work with single groupby', () => {
verify(PIVOT_TABLE_FORM_DATA);
- cy.get('.chart-container tr:eq(0) th:eq(1)').contains('sum__num');
- cy.get('.chart-container tr:eq(1) th:eq(0)').contains('state');
- cy.get('.chart-container tr:eq(2) th:eq(0)').contains('name');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(1)')
+ .contains('sum__num');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(1) th:eq(0)')
+ .contains('state');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(0)')
+ .contains('name');
});
it('should work with more than one groupby', () => {
verify({
...PIVOT_TABLE_FORM_DATA,
groupby: ['name', 'gender'],
});
- cy.get('.chart-container tr:eq(0) th:eq(2)').contains('sum__num');
- cy.get('.chart-container tr:eq(1) th:eq(1)').contains('state');
- cy.get('.chart-container tr:eq(2) th:eq(0)').contains('name');
- cy.get('.chart-container tr:eq(2) th:eq(1)').contains('gender');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(2)')
+ .contains('sum__num');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(1) th:eq(1)')
+ .contains('state');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(0)')
+ .contains('name');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(1)')
+ .contains('gender');
});
it('should work with multiple metrics', () => {
verify({
...PIVOT_TABLE_FORM_DATA,
metrics: ['sum__num', TEST_METRIC],
});
- cy.get('.chart-container tr:eq(0) th:eq(1)').contains('sum__num');
- cy.get('.chart-container tr:eq(0) th:eq(2)').contains('SUM(sum_boys)');
- cy.get('.chart-container tr:eq(1) th:eq(0)').contains('state');
- cy.get('.chart-container tr:eq(2) th:eq(0)').contains('name');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(1)')
+ .contains('sum__num');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(2)')
+ .contains('SUM(sum_boys)');
+ cy.get('[data-test="chart-container"]').find('th:eq(0)').contains('state');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(0)')
+ .contains('name');
});
- it('should work with multiple groupby and multiple metrics', () => {
+ it.only('should work with multiple groupby and multiple metrics', () => {
Review comment:
I don't believe we want the `.only` here, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11134: chore: Cypress all selectors refactor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11134:
URL: https://github.com/apache/incubator-superset/pull/11134#issuecomment-707764135
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=h1) Report
> Merging [#11134](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88af85ac53b62cef9b95fb2f7a069bd460d19c29?el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11134 +/- ##
==========================================
- Coverage 65.60% 60.77% -4.84%
==========================================
Files 832 394 -438
Lines 39400 24716 -14684
Branches 3593 0 -3593
==========================================
- Hits 25849 15020 -10829
+ Misses 13442 9696 -3746
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.77% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [...end/src/components/Select/WindowedSelect/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L2luZGV4LnRzeA==) | | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | | |
| [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | |
| [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
| ... and [383 more](https://codecov.io/gh/apache/incubator-superset/pull/11134/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=footer). Last update [88af85a...dae02cb](https://codecov.io/gh/apache/incubator-superset/pull/11134?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org