You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/04/26 15:36:55 UTC
[native-toolchain-CR] IMPALA-10674: Update toolchain ORC libary for better Iceberg support
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17342
Change subject: IMPALA-10674: Update toolchain ORC libary for better Iceberg support
......................................................................
IMPALA-10674: Update toolchain ORC libary for better Iceberg support
We need the following fixes/features from the ORC library:
* ORC-763: Fix timestamp inconsistencies with Java
* ORC-784: Support setting timezone to timestamp column
* ORC-666: Support timastamp with local timezone (this corresponds
to the Iceberg TIMESTAMPTZ type)
* ORC-781: Make type annotations available from C++ (this is
needed for Iceberg column resolution via field ids)
This commit adds the above via formatted patches.
Testing:
* executed the tests of the ORC library
Change-Id: I72625f4bd6ff3e83ffaaa2c83d31b8ee29c0c35a
---
M buildall.sh
A source/orc/orc-1.6.2-patches/0008-ORC-763-C-Fix-ORC-timestamp-inconsistencies-with-Jav.patch
A source/orc/orc-1.6.2-patches/0009-ORC-784-C-Support-setting-timezone-to-timestamp-colu.patch
A source/orc/orc-1.6.2-patches/0010-ORC-666-C-Support-timestamp-with-local-timezone.patch
A source/orc/orc-1.6.2-patches/0011-ORC-781-C-Make-type-annotations-available-from-C.patch
5 files changed, 1,516 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/42/17342/1
--
To view, visit http://gerrit.cloudera.org:8080/17342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72625f4bd6ff3e83ffaaa2c83d31b8ee29c0c35a
Gerrit-Change-Number: 17342
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] IMPALA-10674: Update toolchain ORC libary for better Iceberg support
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17342 )
Change subject: IMPALA-10674: Update toolchain ORC libary for better Iceberg support
......................................................................
IMPALA-10674: Update toolchain ORC libary for better Iceberg support
We need the following fixes/features from the ORC library:
* ORC-763: Fix timestamp inconsistencies with Java
* ORC-784: Support setting timezone to timestamp column
* ORC-666: Support timastamp with local timezone (this corresponds
to the Iceberg TIMESTAMPTZ type)
* ORC-781: Make type annotations available from C++ (this is
needed for Iceberg column resolution via field ids)
This commit adds the above via formatted patches.
Testing:
* executed the tests of the ORC library
Change-Id: I72625f4bd6ff3e83ffaaa2c83d31b8ee29c0c35a
Reviewed-on: http://gerrit.cloudera.org:8080/17342
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M buildall.sh
A source/orc/orc-1.6.2-patches/0008-ORC-763-C-Fix-ORC-timestamp-inconsistencies-with-Jav.patch
A source/orc/orc-1.6.2-patches/0009-ORC-784-C-Support-setting-timezone-to-timestamp-colu.patch
A source/orc/orc-1.6.2-patches/0010-ORC-666-C-Support-timestamp-with-local-timezone.patch
A source/orc/orc-1.6.2-patches/0011-ORC-781-C-Make-type-annotations-available-from-C.patch
5 files changed, 1,516 insertions(+), 1 deletion(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
Zoltan Borok-Nagy: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I72625f4bd6ff3e83ffaaa2c83d31b8ee29c0c35a
Gerrit-Change-Number: 17342
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] IMPALA-10674: Update toolchain ORC libary for better Iceberg support
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17342 )
Change subject: IMPALA-10674: Update toolchain ORC libary for better Iceberg support
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72625f4bd6ff3e83ffaaa2c83d31b8ee29c0c35a
Gerrit-Change-Number: 17342
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 19:31:57 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10674: Update toolchain ORC libary for better Iceberg support
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17342 )
Change subject: IMPALA-10674: Update toolchain ORC libary for better Iceberg support
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72625f4bd6ff3e83ffaaa2c83d31b8ee29c0c35a
Gerrit-Change-Number: 17342
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 08:06:21 +0000
Gerrit-HasComments: No