You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/29 19:03:00 UTC
[jira] [Commented] (PROTON-2029) applying delivery state to a
locally-settled delivery can cause erroneous disposition frame
[ https://issues.apache.org/jira/browse/PROTON-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829622#comment-16829622 ]
ASF GitHub Bot commented on PROTON-2029:
----------------------------------------
tabish121 commented on pull request #33: PROTON-2029 Add fix and test for extraneous disposition after settle
URL: https://github.com/apache/qpid-proton-j/pull/33
Adds tests for disposition change after settled and a check for settled
state to circumvent more transport work being added when the delivery
has already been tagged as settled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> applying delivery state to a locally-settled delivery can cause erroneous disposition frame
> -------------------------------------------------------------------------------------------
>
> Key: PROTON-2029
> URL: https://issues.apache.org/jira/browse/PROTON-2029
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: proton-j-0.32.0
> Reporter: Robbie Gemmell
> Priority: Minor
>
> If a delivery has disposition state applied and is locally-settled (and the transport output processed), e.g a consumer receiving an unsettled message and acknowledging it, then the unexpected act of applying further delivery state to the delivery object can result in erroneously emitting another disposition frame upon future processing.
> This occurs because applying the state makes adds the delivery to the transport work list again, with the process only being gated on prior remote-settlement to prevent sending a useless notice of settlement. It should also gate on local-settlement to avoid the odd post-settlement state application from actually leading to a disposition frame.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org