You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/02/06 10:34:19 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3667: Use dyn Array in cast kernels
tustvold opened a new pull request, #3667:
URL: https://github.com/apache/arrow-rs/pull/3667
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This makes the kernels easier to use, avoids needless boxing, and is more consistent with the other kernels
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3667: Use dyn Array in cast kernels
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3667:
URL: https://github.com/apache/arrow-rs/pull/3667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3667: Use dyn Array in cast kernels
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #3667:
URL: https://github.com/apache/arrow-rs/pull/3667#discussion_r1097837588
##########
arrow-cast/src/cast.rs:
##########
@@ -609,7 +609,7 @@ pub fn cast_with_options(
// clone array if types are the same
if from_type == to_type {
- return Ok(array.clone());
+ return Ok(make_array(array.data().clone()));
Review Comment:
This one in particular I think is used frequently. I think its additional overhead should be low enough though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3667: Use dyn Array in cast kernels
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3667:
URL: https://github.com/apache/arrow-rs/pull/3667#discussion_r1097205458
##########
arrow-cast/src/cast.rs:
##########
@@ -609,7 +609,7 @@ pub fn cast_with_options(
// clone array if types are the same
if from_type == to_type {
- return Ok(array.clone());
+ return Ok(make_array(array.data().clone()));
Review Comment:
This is the only "downside", in practice cloning ArrayData is relied on to be fast, it underpins array slicing, and so I think this is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3667: Use dyn Array in cast kernels
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3667:
URL: https://github.com/apache/arrow-rs/pull/3667#issuecomment-1419894190
Benchmark runs are scheduled for baseline = a142e5d6b25a8adf4492a6bee9e01dc0e6b8efa9 and contender = b79f27b512d46715e9881e34fe4bb525b88fef9d. b79f27b512d46715e9881e34fe4bb525b88fef9d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/14cef5928e5b4365a933f4c41c2ff789...56359e6d6a19492a84bb135ce34f9e73/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3d3ac75cfa1a43e0b5d777a49d66015a...1c336107203e4a51b7d91d33161d2332/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d87bb4fe42f44c47bb2a8956b2f68b79...ebcc3cb2dd4f4a68aed59d8d5aaa2cd9/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/562de478a0944c28853c6d928fc8535f...2f2a7782cff646e59e40697aeedc9626/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org