You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/01/12 05:43:30 UTC
[PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
panbingkun opened a new pull request, #44702:
URL: https://github.com/apache/spark/pull/44702
### What changes were proposed in this pull request?
The pr is following up
### Why are the changes needed?
Fix issues in comments.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Pass GA.
- Manually test.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44702:
URL: https://github.com/apache/spark/pull/44702#issuecomment-1888578775
LGTM since the PR is already open tho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44702:
URL: https://github.com/apache/spark/pull/44702#discussion_r1449984266
##########
sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala:
##########
@@ -840,7 +840,7 @@ class UDFSuite extends QueryTest with SharedSparkSession {
Row(ArrayBuffer(100)))
val myUdf2 = udf((a: immutable.ArraySeq[Int]) =>
- immutable.ArraySeq.unsafeWrapArray[Int](a.appended(5).appended(6).toArray))
+ immutable.ArraySeq.unsafeWrapArray[Int]((a :+ 5 :+ 6).toArray))
Review Comment:
Can we avoid this kind of followups. and PRs. This is just syntactic sugar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44702:
URL: https://github.com/apache/spark/pull/44702#issuecomment-1888473978
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44702:
URL: https://github.com/apache/spark/pull/44702#discussion_r1449984266
##########
sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala:
##########
@@ -840,7 +840,7 @@ class UDFSuite extends QueryTest with SharedSparkSession {
Row(ArrayBuffer(100)))
val myUdf2 = udf((a: immutable.ArraySeq[Int]) =>
- immutable.ArraySeq.unsafeWrapArray[Int](a.appended(5).appended(6).toArray))
+ immutable.ArraySeq.unsafeWrapArray[Int]((a :+ 5 :+ 6).toArray))
Review Comment:
Can we avoid this kind of followups. and PRs. This is just syntactic sugar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44702:
URL: https://github.com/apache/spark/pull/44702#issuecomment-1888646968
Merged into master. Thanks @panbingkun @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #44702: [SPARK-46586][SQL][TESTS][FOLLOWUP] Replace `appended` with `:+`
URL: https://github.com/apache/spark/pull/44702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org