You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2023/06/09 00:44:18 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
nsivabalan opened a new pull request, #8910:
URL: https://github.com/apache/hudi/pull/8910
### Change Logs
Fixing flaky Continuous mode multi writer tests. Exception thrown when continuous mode job fails is different than exception thrown while backfill job fails. So, had to fix the tests accounting for that.
### Impact
Fixing flaky Continuous mode multi writer tests. Exception thrown when continuous mode job fails is different than exception thrown while backfill job fails. So, had to fix the tests accounting for that.
### Risk level (write none, low medium or high below)
Stabilizes CI
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8910:
URL: https://github.com/apache/hudi/pull/8910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8910:
URL: https://github.com/apache/hudi/pull/8910#issuecomment-1583949317
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fc4825fd3b646e3b69322b386fa4b2fd4f19ba67",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17687",
"triggerID" : "fc4825fd3b646e3b69322b386fa4b2fd4f19ba67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fc4825fd3b646e3b69322b386fa4b2fd4f19ba67 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17687)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #8910:
URL: https://github.com/apache/hudi/pull/8910#discussion_r1223827683
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamerWithMultiWriter.java:
##########
@@ -404,12 +405,24 @@ private void runJobsInParallel(String tableBasePath, HoodieTableType tableType,
* Need to perform getMessage().contains since the exception coming
* from {@link org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer.DeltaSyncService} gets wrapped many times into RuntimeExceptions.
*/
- if (expectConflict && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) {
+ if (expectConflict && backfillFailed.get() && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) {
// expected ConcurrentModificationException since ingestion & backfill will have overlapping writes
- if (backfillFailed.get()) {
+ if (!continuousFailed.get()) {
// if backfill job failed, shutdown the continuous job.
LOG.warn("Calling shutdown on ingestion job since the backfill job has failed for " + jobId);
ingestionJob.shutdownGracefully();
+ } else {
+ // both backfill and ingestion job cannot fail.
+ throw new HoodieException("Both backfilling and ingestion job failed ", e);
+ }
+ } else if (expectConflict && continuousFailed.get() && e.getCause().getMessage().contains("Ingestion service was shut down with exception")) {
+ // incase of regular ingestion job failing, ConcurrentModificationException is not throw all the way.
Review Comment:
nit: `thrown`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8910:
URL: https://github.com/apache/hudi/pull/8910#issuecomment-1583793617
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fc4825fd3b646e3b69322b386fa4b2fd4f19ba67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17687",
"triggerID" : "fc4825fd3b646e3b69322b386fa4b2fd4f19ba67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fc4825fd3b646e3b69322b386fa4b2fd4f19ba67 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17687)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #8910:
URL: https://github.com/apache/hudi/pull/8910#issuecomment-1583934703
we have an unrelated test failure
```
Test Call run_clustering Procedure Order Strategy *** FAILED ***
```
since this patch is also fixing a flaky test, prefer to go ahead w/ landing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8910:
URL: https://github.com/apache/hudi/pull/8910#discussion_r1223690819
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamerWithMultiWriter.java:
##########
@@ -404,12 +405,24 @@ private void runJobsInParallel(String tableBasePath, HoodieTableType tableType,
* Need to perform getMessage().contains since the exception coming
* from {@link org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer.DeltaSyncService} gets wrapped many times into RuntimeExceptions.
*/
- if (expectConflict && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) {
+ if (expectConflict && backfillFailed.get() && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) {
// expected ConcurrentModificationException since ingestion & backfill will have overlapping writes
- if (backfillFailed.get()) {
+ if (!continuousFailed.get()) {
Review Comment:
NTR: in most cases backfill job fails and hence the test succeeds. but if continuous job fails, the test times out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8910:
URL: https://github.com/apache/hudi/pull/8910#issuecomment-1583784756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fc4825fd3b646e3b69322b386fa4b2fd4f19ba67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc4825fd3b646e3b69322b386fa4b2fd4f19ba67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fc4825fd3b646e3b69322b386fa4b2fd4f19ba67 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org