You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kunal Thakar <ku...@uber.com> on 2016/01/04 22:26:13 UTC
Re: Review Request 41809: Allow custom announce path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 9:26 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Added a parameter to the executor to allow custom announce paths.
@ReviewBot retry
Repository: aurora
Description
-------
Allow custom announce path
Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
Diffs (updated)
-----
docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
Diff: https://reviews.apache.org/r/41809/diff/
Testing
-------
Ran unit tests ./pants test src/test/python/apache/aurora:all
Manually tested the changes in vagrant.
Thanks,
Kunal Thakar
Re: Review Request 41809: Allow custom announce path
Posted by Kunal Thakar <ku...@uber.com>.
> On Jan. 4, 2016, 11:13 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/config/schema/base.py, line 102
> > <https://reviews.apache.org/r/41809/diff/2/?file=1181070#file1181070line102>
> >
> > This comment does somewhat imply that I can use a path containing variables. Also the rest of the documentation leaves this somewhat unclear.
Updated the comment to make it more clear hopefully.
- Kunal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112675
-----------------------------------------------------------
On Jan. 5, 2016, 7:51 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 7:51 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112675
-----------------------------------------------------------
src/main/python/apache/aurora/config/schema/base.py (line 102)
<https://reviews.apache.org/r/41809/#comment173180>
This comment does somewhat imply that I can use a path containing variables. Also the rest of the documentation leaves this somewhat unclear.
- Stephan Erb
On Jan. 4, 2016, 10:28 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 10:28 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112653
-----------------------------------------------------------
Ship it!
Master (8706a78) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 4, 2016, 9:28 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 9:28 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112921
-----------------------------------------------------------
Master (b9d9ee3) is red with this patch.
./build-support/jenkins/build.sh
virtualenv-12.1.1/virtualenv_embedded/activate.ps1
virtualenv-12.1.1/virtualenv_embedded/activate.sh
virtualenv-12.1.1/virtualenv_embedded/activate_this.py
virtualenv-12.1.1/virtualenv_embedded/deactivate.bat
virtualenv-12.1.1/virtualenv_embedded/distutils-init.py
virtualenv-12.1.1/virtualenv_embedded/distutils.cfg
virtualenv-12.1.1/virtualenv_embedded/site.py
virtualenv-12.1.1/virtualenv_support/
virtualenv-12.1.1/virtualenv_support/__init__.py
virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3-none-any.whl
virtualenv-12.1.1/virtualenv_support/setuptools-15.0-py2.py3-none-any.whl
+ touch virtualenv-12.1.1/BOOTSTRAPPED
+ popd
~/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.1.1/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip...done.
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
You are using pip version 6.1.1, however version 7.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting isort==4.0.0
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
Using cached isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/announcer.py Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/announcer.py:before 2016-01-05 20:19:12.457020
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/announcer.py:after 2016-01-05 20:24:31.525505
@@ -20,7 +20,7 @@
from kazoo.client import KazooClient
from kazoo.retry import KazooRetry
from mesos.interface import mesos_pb2
-from twitter.common import log, app
+from twitter.common import app, log
from twitter.common.concurrent.deferred import defer
from twitter.common.exceptions import ExceptionalThread
from twitter.common.metrics import LambdaGauge, Observable
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 5, 2016, 7:51 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 7:51 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review113115
-----------------------------------------------------------
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 87)
<https://reviews.apache.org/r/41809/#comment173613>
How would you feel about renaming this (and the corresponding destination) to `announcer-allow-custom-serverset-paths` to make it clear what this flag does? As it's currently named, at first glance I'd expect it to let me set a custom serverset path (i.e. it seems similar to the `announcer-serverset-path` flag).
- Joshua Cohen
On Jan. 5, 2016, 9:33 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:33 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review113136
-----------------------------------------------------------
Ship it!
Master (395bd7d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 6, 2016, 8:47 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 8:47 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Kunal Thakar <ku...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 9:07 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Moved ticket ID to RB bug field.
-wfarner
Bugs: AURORA-1569
https://issues.apache.org/jira/browse/AURORA-1569
Repository: aurora
Description (updated)
-------
Allow custom announce path
Diffs
-----
docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
Diff: https://reviews.apache.org/r/41809/diff/
Testing
-------
Ran tests ./build-support/jenkins/build.sh
Manually tested the changes in vagrant.
Thanks,
Kunal Thakar
Re: Review Request 41809: Allow custom announce path
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review113135
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Jan. 6, 2016, 8:47 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 8:47 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review113181
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 6, 2016, 12:47 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 12:47 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Kunal Thakar <ku...@uber.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 8:47 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Rename --announcer-custom-serverset-path to --announcer-allow-custom-serverset-path. @ReviewBot retry
Repository: aurora
Description
-------
Allow custom announce path
Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
Diffs (updated)
-----
docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
Diff: https://reviews.apache.org/r/41809/diff/
Testing
-------
Ran tests ./build-support/jenkins/build.sh
Manually tested the changes in vagrant.
Thanks,
Kunal Thakar
Re: Review Request 41809: Allow custom announce path
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112937
-----------------------------------------------------------
Ship it!
Master (b9d9ee3) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 5, 2016, 9:33 p.m., Kunal Thakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:33 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom announce path
>
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
>
>
> Diffs
> -----
>
> docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
> src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
> src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
>
> Diff: https://reviews.apache.org/r/41809/diff/
>
>
> Testing
> -------
>
> Ran tests ./build-support/jenkins/build.sh
> Manually tested the changes in vagrant.
>
>
> Thanks,
>
> Kunal Thakar
>
>
Re: Review Request 41809: Allow custom announce path
Posted by Kunal Thakar <ku...@uber.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 9:33 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Fix import ordering @ReviewBot retry
Repository: aurora
Description
-------
Allow custom announce path
Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
Diffs (updated)
-----
docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
Diff: https://reviews.apache.org/r/41809/diff/
Testing
-------
Ran tests ./build-support/jenkins/build.sh
Manually tested the changes in vagrant.
Thanks,
Kunal Thakar
Re: Review Request 41809: Allow custom announce path
Posted by Kunal Thakar <ku...@uber.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 7:51 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Updated to fail executor if executor is not started with --announcer-custom-serverset-path and zk_path is provided. @ReviewBot retry
Repository: aurora
Description
-------
Allow custom announce path
Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
Diffs (updated)
-----
docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
Diff: https://reviews.apache.org/r/41809/diff/
Testing
-------
Ran tests ./build-support/jenkins/build.sh
Manually tested the changes in vagrant.
Thanks,
Kunal Thakar
Re: Review Request 41809: Allow custom announce path
Posted by Kunal Thakar <ku...@uber.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 9:28 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
-------
Allow custom announce path
Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
Diffs
-----
docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b
src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b0278d31654c3c51ff149bc4167aaf94041ec
src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d
src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955
Diff: https://reviews.apache.org/r/41809/diff/
Testing (updated)
-------
Ran tests ./build-support/jenkins/build.sh
Manually tested the changes in vagrant.
Thanks,
Kunal Thakar