You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/21 23:34:34 UTC
[GitHub] [doris] stalary opened a new pull request, #10327: [Enhancement] modify comment " to ' compat mysql.
stalary opened a new pull request, #10327:
URL: https://github.com/apache/doris/pull/10327
# Proposed changes
Issue Number: close https://github.com/apache/doris/issues/10203
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary closed pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
stalary closed pull request #10327: [Enhancement] modify comment " to ' compat mysql.
URL: https://github.com/apache/doris/pull/10327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #10327:
URL: https://github.com/apache/doris/pull/10327#discussion_r903228619
##########
fe/fe-core/src/test/java/org/apache/doris/analysis/ShowCreateTableStmtTest.java:
##########
@@ -18,46 +18,36 @@
package org.apache.doris.analysis;
import org.apache.doris.common.AnalysisException;
-import org.apache.doris.mysql.privilege.MockedAuth;
-import org.apache.doris.mysql.privilege.PaloAuth;
-import org.apache.doris.qe.ConnectContext;
-
-import mockit.Mocked;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
-
-public class ShowCreateTableStmtTest {
- private Analyzer analyzer;
-
- @Mocked
- private PaloAuth auth;
- @Mocked
- private ConnectContext ctx;
-
- @Before
- public void setUp() {
- analyzer = AccessTestUtil.fetchAdminAnalyzer(true);
- MockedAuth.mockedAuth(auth);
- MockedAuth.mockedConnectContext(ctx, "root", "192.168.1.1");
+import org.apache.doris.common.DdlException;
Review Comment:
Ok, it is still in the development stage, I will deal with it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #10327:
URL: https://github.com/apache/doris/pull/10327#discussion_r903227171
##########
fe/fe-core/src/test/java/org/apache/doris/analysis/ShowCreateTableStmtTest.java:
##########
@@ -18,46 +18,36 @@
package org.apache.doris.analysis;
import org.apache.doris.common.AnalysisException;
-import org.apache.doris.mysql.privilege.MockedAuth;
-import org.apache.doris.mysql.privilege.PaloAuth;
-import org.apache.doris.qe.ConnectContext;
-
-import mockit.Mocked;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
-
-public class ShowCreateTableStmtTest {
- private Analyzer analyzer;
-
- @Mocked
- private PaloAuth auth;
- @Mocked
- private ConnectContext ctx;
-
- @Before
- public void setUp() {
- analyzer = AccessTestUtil.fetchAdminAnalyzer(true);
- MockedAuth.mockedAuth(auth);
- MockedAuth.mockedConnectContext(ctx, "root", "192.168.1.1");
+import org.apache.doris.common.DdlException;
Review Comment:
Use `control+option+o` remove unused header.
[Doc about it](https://doris.apache.org/zh-CN/developer/developer-guide/java-format-code.html#import-order)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #10327:
URL: https://github.com/apache/doris/pull/10327#issuecomment-1163757677
I found that this did not solve the superset presentation problem and that the change affected many UT and Regression, so I close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10327:
URL: https://github.com/apache/doris/pull/10327#issuecomment-1170612085
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #10327:
URL: https://github.com/apache/doris/pull/10327#issuecomment-1165659768
superset and dathub use sqlalchemy by `show create table` sql get metadataļ¼Standard mysql syntax, comment uses single quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10327:
URL: https://github.com/apache/doris/pull/10327#issuecomment-1170612058
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10327:
URL: https://github.com/apache/doris/pull/10327#issuecomment-1171812353
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10327: [Enhancement] modify comment " to ' compat mysql.
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10327:
URL: https://github.com/apache/doris/pull/10327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org