You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/08 22:42:27 UTC

[GitHub] [pinot] walterddr commented on pull request #8860: fix data table vs. block format issue

walterddr commented on PR #8860:
URL: https://github.com/apache/pinot/pull/8860#issuecomment-1150484456

   > There are several inefficiency in the current data table implementation. I'd suggest making a V4 to address the inefficiency instead of making the new code follow the bad format.
   > 
   > Things we want to improve:
   > 
   > * Store float as 4 bytes
   > * Do not serialize bytes to string
   > * For each column, add an optional bitmap to store the nulls for the column
   
   ok. in this case I would suggest we add FLOAT/BYTES to the ignore list and still merge the integration test PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org