You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/02 05:24:26 UTC
[GitHub] [helix] pkuwm opened a new pull request #1206: Update issue management with github issues
pkuwm opened a new pull request #1206:
URL: https://github.com/apache/helix/pull/1206
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1204
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
Helix pom still sets jira as the issue management. It should be updated to Apache Helix GitHub issues.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
```
mvn site
[INFO] Rendering site with default locale English (en)
[INFO] Relativizing decoration links with respect to localized project URL: http://helix.apache.org/recipes/service-discovery
[INFO] Rendering content with org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
[INFO] Generating "Source Xref" report --- maven-jxr-plugin:3.0.0:jxr
[INFO] Generating "CI Management" report --- maven-project-info-reports-plugin:3.0.0:ci-management
[INFO] Generating "Dependencies" report --- maven-project-info-reports-plugin:3.0.0:dependencies
[INFO] Generating "Dependency Information" report --- maven-project-info-reports-plugin:3.0.0:dependency-info
[INFO] Generating "Dependency Management" report --- maven-project-info-reports-plugin:3.0.0:dependency-management
[INFO] Generating "Distribution Management" report --- maven-project-info-reports-plugin:3.0.0:distribution-management
[INFO] Generating "About" report --- maven-project-info-reports-plugin:3.0.0:index
[INFO] Generating "Issue Management" report --- maven-project-info-reports-plugin:3.0.0:issue-management
[INFO] Generating "Licenses" report --- maven-project-info-reports-plugin:3.0.0:licenses
[INFO] Generating "Mailing Lists" report --- maven-project-info-reports-plugin:3.0.0:mailing-lists
[INFO] Generating "Plugin Management" report --- maven-project-info-reports-plugin:3.0.0:plugin-management
[INFO] Generating "Plugins" report --- maven-project-info-reports-plugin:3.0.0:plugins
[INFO] Generating "Source Code Management" report --- maven-project-info-reports-plugin:3.0.0:scm
[INFO] Generating "Summary" report --- maven-project-info-reports-plugin:3.0.0:summary
[INFO] Generating "Team" report --- maven-project-info-reports-plugin:3.0.0:team
[INFO] Generating "Sonar" report --- maven-report:0.1:report
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Helix 1.0.2-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 41.946 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 3.780 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 18.297 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 3.123 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 1.969 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 5.277 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 4.270 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 13.467 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 7.347 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 4.432 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.389 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 2.572 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 2.354 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 2.080 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 2.277 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 2.160 s]
[INFO] ------------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index d613d44c9..a0f63a0c4 100644
--- a/pom.xml
+++ b/pom.xml
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:56 min
[INFO] Finished at: 2020-08-01T21:51:16-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1206:
URL: https://github.com/apache/helix/pull/1206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1206:
URL: https://github.com/apache/helix/pull/1206#discussion_r464212894
##########
File path: pom.xml
##########
@@ -367,8 +367,8 @@ under the License.
<tag>HEAD</tag>
</scm>
<issueManagement>
- <system>jira</system>
- <url>https://issues.apache.org/jira/browse/HELIX</url>
+ <system>Github</system>
+ <url>https://github.com/apache/helix/issues</url>
Review comment:
Thanks for making this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1206:
URL: https://github.com/apache/helix/pull/1206#issuecomment-668383525
Let's hold on this change before discussing it with the whole Helix committee.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1206:
URL: https://github.com/apache/helix/pull/1206#issuecomment-686761013
@pkuwm Please update here if you have notified the Helix community about this proposal. So I can approve it if no one has concern about the plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1206:
URL: https://github.com/apache/helix/pull/1206#issuecomment-696301598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1206:
URL: https://github.com/apache/helix/pull/1206#issuecomment-696301598
@jiajunwang I've sent an email to helix-dev. No one is giving any concern about this. I think it is good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1206:
URL: https://github.com/apache/helix/pull/1206#discussion_r464213025
##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.2</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.maven.doxia</groupId>
- <artifactId>doxia-module-markdown</artifactId>
- <version>1.3</version>
- </dependency>
- </dependencies>
+ <version>3.9.1</version>
Review comment:
We might need to be a little more careful about making this change - this might mess up the Apache Helix main page...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1206:
URL: https://github.com/apache/helix/pull/1206#issuecomment-696337766
This PR is ready to be merged, approved by @jiajunwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1206: Update issue management with github issues
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1206:
URL: https://github.com/apache/helix/pull/1206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org