You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ivan Vasilev (JIRA)" <ji...@apache.org> on 2010/11/28 00:25:38 UTC
[jira] Created: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Form with UploadProgressBar and AjaxButton doesn't submit
---------------------------------------------------------
Key: WICKET-3202
URL: https://issues.apache.org/jira/browse/WICKET-3202
Project: Wicket
Issue Type: Bug
Components: wicket, wicket-extensions
Affects Versions: 1.5-M3
Environment: Windows 7, java 1.6
Reporter: Ivan Vasilev
Attachments: quickstart.rar
There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970238#action_12970238 ]
Pedro Santos commented on WICKET-3202:
--------------------------------------
Even for Chrome and Safari? OK, I will study then a little more.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970879#action_12970879 ]
Martin Grigorov commented on WICKET-3202:
-----------------------------------------
Looks good.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Pedro Santos
> Attachments: quickstart.rar, WICKET-3202-using-iframe.patch, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970276#action_12970276 ]
Pedro Santos commented on WICKET-3202:
--------------------------------------
Looks like a bug. We can continue having the progress bar updated sending AJAX requests in an created iframe. I will give a try.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969277#action_12969277 ]
Paul commented on WICKET-3202:
------------------------------
Have you tried using IE or another Browser?
I had the same Problem while using IE. Using other Browsers like Firefox, Chrome, etc. it works fine, just IE doesn't do anything with the Uploadprogressbar present and a Ajax-Submit.
This problem also occurs while using a AjaxSubmitLink.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971523#action_12971523 ]
Hudson commented on WICKET-3202:
--------------------------------
Integrated in Apache Wicket 1.4.x #328 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/328/])
using an iframe to do the asynchronous progress bar update
Issue: WICKET-3202
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Pedro Santos
> Fix For: 1.4.15, 1.5-M4
>
> Attachments: quickstart.rar, WICKET-3202-using-iframe.patch, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-3202:
-------------------------------------
Assignee: Pedro Santos (was: Igor Vaynberg)
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Pedro Santos
> Attachments: quickstart.rar, WICKET-3202-using-iframe.patch, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3202:
---------------------------------
Attachment: WICKET-3202-using-wicket-ajax.patch
I noticed that Chrome and Safari do not process the AJAX request to update the progress bar during the data upload. So it is also important to submit the form using an AJAX submit component that will submit the form targeting an created iframe in the page DOM (wicket-ajax.js do that).
So I'm sending an new patch explaing it on the javadoc and using the Wicket JavaScript AJAX API (solving the problem of wicket-event.js using the Wicket.$ function).
I tested on IE 6,7,8, Safari, Chrome, Firefox, only on Safari and Chrome the regular form submit don't update the progress bar (expected). But even not presenting the progress on the UploadProgressBar, Chrome shows an progress status at the window bottom.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3202:
---------------------------------
Attachment: WICKET-3202.patch
I'm sending a patch fixing the bug for IE 7, 8, chrome and firefox
On safari only the ajax submit button/link works, the regular submit button only present the progress bar but do not update the state.
I tested the quickstart at WICKET-3181 and the progress bar is presented and updated correctly, the problem is that the bytes uploaded info do not get updated. So the progress bar keep presenting 0% of <size>MB completed.
Patch fix:
- the UploadStatusResource was retuning an state with incorrect value for remainingTimeString varible
- the progressbar.js was not hiding the status bar when there wasn't UploadInfo at UploadWebRequest (can happen if user did not use the UploadWebRequest as the Application WebRequest)
- use the onsubmit callback instead of submit because the wicket-ajax.js use the submit method to submit the multipart form. Doing so the registered submit callback was not get called. Use Wicket.Event.fire to trigger the form submit do not work on IE, so register the callback at the submit is problematic.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969701#action_12969701 ]
Pedro Santos commented on WICKET-3202:
--------------------------------------
The wicket-ajax.js is calling form.submit() when the user click at an ajax button. But it is not executing the UploadProgressBar submit callback registered for the form element. I'm trying to find a good solution yet.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos resolved WICKET-3202.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
1.4.15
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Pedro Santos
> Fix For: 1.4.15, 1.5-M4
>
> Attachments: quickstart.rar, WICKET-3202-using-iframe.patch, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3202:
---------------------------------
Attachment: WICKET-3202-using-iframe.patch
Patch using an iframe to do the asynchronous progress bar update. Tested on IE 6,7,8, Fireforx, Safari, Chrome. Working for AJAX and regular submit.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202-using-iframe.patch, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970236#action_12970236 ]
Igor Vaynberg commented on WICKET-3202:
---------------------------------------
iirc normal form submits should have a working progress bars...
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Ivan Vasilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Vasilev updated WICKET-3202:
---------------------------------
Attachment: quickstart.rar
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Attachments: quickstart.rar
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3202) Form with
UploadProgressBar and AjaxButton doesn't submit
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970276#action_12970276 ]
Pedro Santos edited comment on WICKET-3202 at 12/10/10 2:08 PM:
----------------------------------------------------------------
Looks like a bug in webkit based browser [1]. We can continue having the progress bar updated sending AJAX requests in an created iframe. I will give a try.
1: http://stackoverflow.com/questions/3185238
was (Author: pedrosans):
Looks like a bug. We can continue having the progress bar updated sending AJAX requests in an created iframe. I will give a try.
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar, WICKET-3202-using-wicket-ajax.patch, WICKET-3202.patch
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3202) Form with UploadProgressBar and
AjaxButton doesn't submit
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3202.
-----------------------------------
Resolution: Cannot Reproduce
Assignee: Igor Vaynberg
cannot reproduce with current snapshot. you are also missing this in the application class:
+
+ @Override
+ protected WebRequest newWebRequest(HttpServletRequest servletRequest,
+ String filterPath) {
+ return new UploadWebRequest(servletRequest, filterPath);
+ }
> Form with UploadProgressBar and AjaxButton doesn't submit
> ---------------------------------------------------------
>
> Key: WICKET-3202
> URL: https://issues.apache.org/jira/browse/WICKET-3202
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.5-M3
> Environment: Windows 7, java 1.6
> Reporter: Ivan Vasilev
> Assignee: Igor Vaynberg
> Attachments: quickstart.rar
>
>
> There is a Form and a FIleUploadField and UploadProgressBar in it. The form is submitted via AjaxButton. If the user tries to upload a file, nothing happens (at least nothing on the server side). If the UploadProgressBar is removed from the form everything works fine. This behavior can be observed in the attached quickstart. Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.