You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2015/05/13 15:01:04 UTC
[Issue 126305] New: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Issue ID: 126305
Issue Type: DEFECT
Summary: WebDAV lock on 4.1.1 does not work
Product: General
Version: 4.1.1
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Priority: P5
Component: code
Assignee: issues@openoffice.apache.org
Reporter: giuseppe.castagno@acca-esse.eu
When serf library was added to AOO, the WebDAV lock file feature was not
implemented.
To check it, you should have a WebDAV server available, on which the lock
feature is enabled.
This can be achieved on both Linux or Windows 7 Professional, instruction to do
this can be found on the Internet.
On Windows 7 Professional only the Basic authentication will work, current AOO
serf version does not have Windows authentication.
Try to access the same file on the WebDAV server with AOO 4.1.1 from two
different PC at the same time and both of them will permit modification of the
file.
I'll attach a patch that implements the WebDAV lock, only for files, WebDAV
lock on containers (directory) is not implemented.
The implementation is according to RFC4918, plus errata.
The main project where the changes are located is ucb.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #24 from Andrea Pescetti <pe...@apache.org> ---
Thanks, setting VERIFIED after we got confirmation on list that 4.1.2-RC2 Mac
OS X works too.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #2 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
See issue 126312 for a better use in some Windows installation where Windows
authentication is needed.
See issue 125194 for an issue with roots in WebDAV lock problem, but solved in
another way.
--
You are receiving this mail because:
You are the assignee for the issue.
review requested: [Issue 126305] WebDAV lock on 4.1.1 does not work
: [Attachment 84784] Proposed patch to fix the issue, version #2
Posted by bu...@apache.org.
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> has asked
for review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Attachment 84784: Proposed patch to fix the issue, version #2
https://bz.apache.org/ooo/attachment.cgi?id=84784&action=edit
--- Comment #3 from Giuseppe Castagno (aka beppec56)
<gi...@acca-esse.eu> ---
Created attachment 84784
--> https://bz.apache.org/ooo/attachment.cgi?id=84784&action=edit
Proposed patch to fix the issue, version #2
The patch is rebased on trunk, r1683442.
It completely replaces the former one.
I added the placeholder '//->i126305' where changes where made (sfx2,
ucbhelper, comphelper, offapi, ucb).
The patch was built successfully both on Linux (Ubuntu 14.04 64bit) and Windows
(Windows 7 64bit).
Changes from the previous patch version:
- fixed a regression while doing copy/paste among AOO application;
- added a correct refresh of the document while turning it to r/w from r/o
(e.g. when the other user releases the lock on the WebDAV resource). This same
refresh is operating even when you try to switch from r/o to r/w and the
document is reported as still locked, so the user can see the current document
state;
- corrected a wrong behaviour existent in AOO 4.1.1, where the edit button on
toolbar stop functioning after you try it several time and the file is still
locked by another user;
- shortened the refresh time of the lock because some WebDAV servers even
though they are HTTP/1.1 after some time they return an error that is mapped by
serf to 'connection closed by peer'.
Time was reduced from 3 minutes down to 2 minutes to solve the problem.
- removed some unused white spaces while I was at it...
In my own opinion, this patch should be evaluated to be added to AOO 4.1.2
version.
4.1.2_release_blocker requested: [Issue 126305] WebDAV lock on 4.1.1
does not work
Posted by bu...@apache.org.
Andrea Pescetti <pe...@apache.org> has asked for 4.1.2_release_blocker:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #6 from Andrea Pescetti <pe...@apache.org> ---
Nominating as blocker for OpenOffice 4.1.2. This is the second patch in a set
of three patches that, combined, solve a major interoperability (Sharepoint)
bug.
review requested: [Issue 126305] WebDAV lock on 4.1.1 does not work
: [Attachment 84822] Proposed patch to fix the issue, version #3
Posted by bu...@apache.org.
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> has asked
for review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Attachment 84822: Proposed patch to fix the issue, version #3
https://bz.apache.org/ooo/attachment.cgi?id=84822&action=edit
--- Comment #5 from Giuseppe Castagno (aka beppec56)
<gi...@acca-esse.eu> ---
Created attachment 84822
--> https://bz.apache.org/ooo/attachment.cgi?id=84822&action=edit
Proposed patch to fix the issue, version #3
Updated version of the patch.
Fixes a small error in protocol testing in framework that prevented correct
checking against https:// protocol.
Polished the comment a little.
IMHO it ca be used for inclusion in trunk, rebased on trunk r1687177.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #8 from SVN Robot <sv...@dev.null.org> ---
"pescetti" committed SVN revision 1705200 into branches/AOO410:
#i126305# Fix typo that prevents merging from trunk.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
oooforum <oo...@free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Issue Type|DEFECT |PATCH
CC| |oooforum@free.fr
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #23 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Verified in Linux (64bit) and Windows (32bit): found fixed.
--
You are receiving this mail because:
You are the assignee for the issue.
4.1.2_release_blocker granted: [Issue 126305] WebDAV lock on 4.1.1
does not work
Posted by bu...@apache.org.
Andrea Pescetti <pe...@apache.org> has granted Andrea Pescetti
<pe...@apache.org>'s request for 4.1.2_release_blocker:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #19 from Andrea Pescetti <pe...@apache.org> ---
Reopening due to the (easy) fix proposed on the dev list:
http://www.mail-archive.com/dev@openoffice.apache.org/msg25156.html
Giuseppe, are you going to implement the change yourself? Due to the nature of
this change, a patch with respect to the current trunk would be best.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #7 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
The proposed patch could have regressions because was tested only with a
limited set of WebDAV servers.
--
You are receiving this mail because:
You are the assignee for the issue.
review requested: [Issue 126305] WebDAV lock on 4.1.1 does not work
: [Attachment 84738] Add lock functionality to WebDAV, according to RFC4918
Posted by bu...@apache.org.
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> has asked
for review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Attachment 84738: Add lock functionality to WebDAV, according to RFC4918
https://bz.apache.org/ooo/attachment.cgi?id=84738&action=edit
--- Comment #1 from Giuseppe Castagno (aka beppec56)
<gi...@acca-esse.eu> ---
Created attachment 84738
--> https://bz.apache.org/ooo/attachment.cgi?id=84738&action=edit
Add lock functionality to WebDAV, according to RFC4918
The patch is rebased on trunk, r1678268.
I added the placeholder '//->i126305' where changes where made in ucb client
applications (sfx2, ucbhelper, comphelper, offapi),
I didn't do that in ucb, where the changes are substantial.
Other placeholder are 'i12605 TODO' something that works but I'm not sure I did
the right choice,
in this case suggestions welcome.
The patch was built successfully both on Linux (Ubuntu 14.04 64bit) and Windows
(Windows 7 64bit).
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Flags|4.1.2_release_blocker? |4.1.2_release_blocker+
Status|RESOLVED |REOPENED
--- Comment #19 from Andrea Pescetti <pe...@apache.org> ---
Reopening due to the (easy) fix proposed on the dev list:
http://www.mail-archive.com/dev@openoffice.apache.org/msg25156.html
Giuseppe, are you going to implement the change yourself? Due to the nature of
this change, a patch with respect to the current trunk would be best.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
davide@flossconsulting.it changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |davide@flossconsulting.it
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #18 from Andrea Pescetti <pe...@apache.org> ---
The current trunk and AOO410 have the patch by Giuseppe and the following build
fixes by Don.
Adjusted by pfg with
http://svn.apache.org/r1705551 (trunk)
http://svn.apache.org/r1705552 (AOO410)
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #17 from Andrea Pescetti <pe...@apache.org> ---
A different version of Don's patch has been committed to trunk and merged to
AOO410 by pfg.
Relevant commits for tracking:
http://svn.apache.org/r1705542
http://svn.apache.org/r1705543
http://svn.apache.org/r1705547
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #21 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Created attachment 84972
--> https://bz.apache.org/ooo/attachment.cgi?id=84972&action=edit
Path to fix access to non webdav sites
This patch fix access to web site not implementing webdav or to site that are
read-only webdav.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #20 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Created attachment 84971
--> https://bz.apache.org/ooo/attachment.cgi?id=84971&action=edit
Move an added enum as the last one
The proposed patch move the new enum to the last position.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #11 from SVN Robot <sv...@dev.null.org> ---
"pescetti" committed SVN revision 1705247 into branches/AOO410:
#i126305# Temporary revert build breaker (limited to the AOO410 branch).
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.1.2
CC| |pescetti@apache.org
--- Comment #4 from Andrea Pescetti <pe...@apache.org> ---
Setting target 4.1.2 as per discussions in mailing list and issue comments.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
truckman <dl...@catspoiler.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dl-openoffice@catspoiler.or
| |g
--- Comment #16 from truckman <dl...@catspoiler.org> ---
Created attachment 84961
--> https://bz.apache.org/ooo/attachment.cgi?id=84961&action=edit
patch to unbreak the FreeBSD port build after the proposed patch was committed
This change broke the FreeBSD port build, which uses --with-system-apr and
--with-system-serf. The attached patch fixes this problem, and builds of trunk
without these two options are also successful on FreeBSD..
A similar change was made to trunk in r1654282 to fix other files under webdav.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kschenk@apache.org
Status|VERIFIED |CLOSED
--- Comment #25 from Kay <ks...@apache.org> ---
Closing.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Tassoman <ta...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tassoman@gmail.com
--
You are receiving this mail because:
You are the assignee for the issue.
review canceled: [Issue 126305] WebDAV lock on 4.1.1 does not work :
[Attachment 84738] Add lock functionality to WebDAV, according to RFC4918
Posted by bu...@apache.org.
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> has canceled
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu>'s request for
review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Attachment 84738: Add lock functionality to WebDAV, according to RFC4918
https://bz.apache.org/ooo/attachment.cgi?id=84738&action=edit
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84784|review? |
Flags| |
Attachment #84784|0 |1
is obsolete| |
Attachment #84822| |review?
Flags| |
--- Comment #5 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Created attachment 84822
--> https://bz.apache.org/ooo/attachment.cgi?id=84822&action=edit
Proposed patch to fix the issue, version #3
Updated version of the patch.
Fixes a small error in protocol testing in framework that prevented correct
checking against https:// protocol.
Polished the comment a little.
IMHO it ca be used for inclusion in trunk, rebased on trunk r1687177.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |4.1.2_release_blocker?
--- Comment #6 from Andrea Pescetti <pe...@apache.org> ---
Nominating as blocker for OpenOffice 4.1.2. This is the second patch in a set
of three patches that, combined, solve a major interoperability (Sharepoint)
bug.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #22 from Andrea Pescetti <pe...@apache.org> ---
Both patches by Giuseppe are now committed to trunk and to AOO410 for
OpenOffice 4.1.2.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #9 from SVN Robot <sv...@dev.null.org> ---
"pescetti" committed SVN revision 1705199 into trunk:
#i126305# Add support for WebDAV locking.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84738|review? |
Flags| |
Attachment #84738|0 |1
is obsolete| |
Attachment #84784| |review?
Flags| |
--- Comment #3 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Created attachment 84784
--> https://bz.apache.org/ooo/attachment.cgi?id=84784&action=edit
Proposed patch to fix the issue, version #2
The patch is rebased on trunk, r1683442.
It completely replaces the former one.
I added the placeholder '//->i126305' where changes where made (sfx2,
ucbhelper, comphelper, offapi, ucb).
The patch was built successfully both on Linux (Ubuntu 14.04 64bit) and Windows
(Windows 7 64bit).
Changes from the previous patch version:
- fixed a regression while doing copy/paste among AOO application;
- added a correct refresh of the document while turning it to r/w from r/o
(e.g. when the other user releases the lock on the WebDAV resource). This same
refresh is operating even when you try to switch from r/o to r/w and the
document is reported as still locked, so the user can see the current document
state;
- corrected a wrong behaviour existent in AOO 4.1.1, where the edit button on
toolbar stop functioning after you try it several time and the file is still
locked by another user;
- shortened the refresh time of the lock because some WebDAV servers even
though they are HTTP/1.1 after some time they return an error that is mapped by
serf to 'connection closed by peer'.
Time was reduced from 3 minutes down to 2 minutes to solve the problem.
- removed some unused white spaces while I was at it...
In my own opinion, this patch should be evaluated to be added to AOO 4.1.2
version.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #10 from SVN Robot <sv...@dev.null.org> ---
"pescetti" committed SVN revision 1705201 into branches/AOO410:
#i126305# Add support for WebDAV locking.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #15 from Andrea Pescetti <pe...@apache.org> ---
Build issues were due to an incomplete commit. The patch has now been applied
properly to AOO410 for OpenOffice 4.1.2.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #13 from SVN Robot <sv...@dev.null.org> ---
"pescetti" committed SVN revision 1705276 into trunk:
#i126305# Add missing files from the patch.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84738| |review?
Flags| |
--- Comment #1 from Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> ---
Created attachment 84738
--> https://bz.apache.org/ooo/attachment.cgi?id=84738&action=edit
Add lock functionality to WebDAV, according to RFC4918
The patch is rebased on trunk, r1678268.
I added the placeholder '//->i126305' where changes where made in ucb client
applications (sfx2, ucbhelper, comphelper, offapi),
I didn't do that in ucb, where the changes are substantial.
Other placeholder are 'i12605 TODO' something that works but I'm not sure I did
the right choice,
in this case suggestions welcome.
The patch was built successfully both on Linux (Ubuntu 14.04 64bit) and Windows
(Windows 7 64bit).
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #12 from Andrea Pescetti <pe...@apache.org> ---
Apparently this breaks the build in AOO410 (offapi module), so it's temporarily
reverted until it can be checked better. It remains fixed on trunk, where build
is OK.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126305] WebDAV lock on 4.1.1 does not work
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126305
--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"pescetti" committed SVN revision 1705278 into branches/AOO410:
#i126305# Apply the full WebDAV patch.
--
You are receiving this mail because:
You are the assignee for the issue.
review canceled: [Issue 126305] WebDAV lock on 4.1.1 does not work :
[Attachment 84784] Proposed patch to fix the issue, version #2
Posted by bu...@apache.org.
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu> has canceled
Giuseppe Castagno (aka beppec56) <gi...@acca-esse.eu>'s request for
review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305
Attachment 84784: Proposed patch to fix the issue, version #2
https://bz.apache.org/ooo/attachment.cgi?id=84784&action=edit