You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Danori (via GitHub)" <gi...@apache.org> on 2024/04/17 19:54:04 UTC
[PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Danori opened a new pull request, #3781:
URL: https://github.com/apache/ambari/pull/3781
## What changes were proposed in this pull request?
Resolves "is" and "is not" compiler warnings introduced in python 3.8 when comparing literals.
See https://discuss.python.org/t/demoting-the-is-operator-to-avoid-an-identity-crisis/86 for more details.
Before:
After:
## How was this patch tested?
Manual test / validation in custom Rocky Linux 9 docker environment (planning on contributing support for Redhat 9 in the near future)
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065284513
If you want to create the PR again, let me revert the commit first and then you can re-create the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2063030800
@virajjasani I encountered a similar warning message, and this modification looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "wenwj0 (via GitHub)" <gi...@apache.org>.
wenwj0 commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2063971242
Thanks @Danori, I encountered these warnings too. It appears in python 3.8+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065280503
@Danori are you referring to (#2) reference in the commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2063026503
The changes look good overall. @JiaLiangC you also want to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065295488
Alright, I have taken care of this, no worries. Thank you everyone, once again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #3781:
URL: https://github.com/apache/ambari/pull/3781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2064614592
Thank you @JiaLiangC @Danori @wenwj0, merging the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065282760
Looks like my bad, i did squash & merge, not sure why the PR title was not retained. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Posted by "Danori (via GitHub)" <gi...@apache.org>.
Danori commented on PR #3781:
URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065062641
Oh looks like my commit didn't follow the typical conventions; would you guys like me to amend my commit before we merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org