[jira] [Commented] (HADOOP-15455) Incorrect debug message in KMSACL#hasAccess

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470906#comment-16470906 ] 

ASF GitHub Bot commented on HADOOP-15455:
-----------------------------------------

GitHub user phstudy opened a pull request:

    https://github.com/apache/hadoop/pull/385

    HADOOP-15455. Incorrect debug message in KMSACL#hasAccess

    Fix debug message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phstudy/hadoop patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #385
    
----
commit a7a0aa7aef2c47f289fd8c5b7c6a5e4c6cecf1c0
Author: Yuen-Kuei Hsueh <ph...@...>
Date:   2018-05-10T18:23:41Z

    HADOOP-15455. Incorrect debug message in KMSACL#hasAccess
    
    Fix debug message.

----


> Incorrect debug message in KMSACL#hasAccess
> -------------------------------------------
>
>                 Key: HADOOP-15455
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15455
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Wei-Chiu Chuang
>            Priority: Trivial
>
> If the user is in the blacklist "foo bar", it prints "user is not in foo bar".
> else, it prints "user is in foo bar"
> {code:title=KMSACLs#hasAccess()}
> if (access) {
>       AccessControlList blacklist = blacklistedAcls.get(type);
>       access = (blacklist == null) || !blacklist.isUserInList(ugi);
>       if (LOG.isDebugEnabled()) {
>         if (blacklist == null) {
>           LOG.debug("No blacklist for {}", type.toString());
>         } else if (access) {
>           LOG.debug("user is in {}" , blacklist.getAclString());
>         } else {
>           LOG.debug("user is not in {}" , blacklist.getAclString());
>         }
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org