You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/18 13:57:15 UTC

[GitHub] [airflow] OmerJog commented on issue #5428: AIRFLOW-4809 | s3_delete_objects_operator should not fail on empty list of keys

OmerJog commented on issue #5428: AIRFLOW-4809 | s3_delete_objects_operator should not fail on empty list of keys
URL: https://github.com/apache/airflow/pull/5428#issuecomment-503147121
 
 
   One might argue that this is the expected behavior.
   The hook just expose the behavior given with boto, in my opinion we shouldnt overwrite this behavior.
   
   Why shouldnt this be raises as PR in boto itself?
   
   BTW one might also ask if a list was given but there was nothing to delete should it fail ot success? This should be defined by the library (in this case boto) not by Airflow.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services