[GitHub] [netbeans] mbien commented on a diff in pull request #5121: Fixing pattern matching for binding patterns

[GitBox <gi...@apache.org>]

mbien commented on code in PR #5121:
URL: https://github.com/apache/netbeans/pull/5121#discussion_r1053461558


##########
java/spi.java.hints/test/unit/src/org/netbeans/modules/java/hints/spiimpl/UtilitiesTest.java:
##########
@@ -380,9 +380,9 @@ public void testCasePattern() throws Exception {
         String golden = "case $expr: foo bar; $stmts$; ";
         assertEquals(golden.replaceAll("[ \n\r]+", " "), result.toString().replaceAll("[ \n\r]+", " "));
         assertDiagnostics(errors, "19-19:compiler.err.expected");
-        assertPositions(result, positions[0], code, "$expr", "$stmts$", "$stmts$;", "case $expr: foo bar $stmts$;", "foo", "foo bar ");
+        assertPositions(result, positions[0], code, "$expr", "$expr", "$stmts$", "$stmts$;", "case $expr: foo bar $stmts$;", "foo", "foo bar ");
     }
-*/

Review Comment:
   awesome. Good to see this test case enabled.
   I wanted to do that in:
   https://github.com/apache/netbeans/pull/5107#discussion_r1047673049
   when we enabled tests for this module (and many others) which was completely turned off till now.
   
   but I wasn't sure if the result was actually correct. So I commented it out instead of running the risk to commit a wrong test assumption.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists