[GitHub] [seatunnel] Hisoka-X commented on pull request #5328: [Feature][Catalog] Catalog add indent

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on PR #5328:
URL: https://github.com/apache/seatunnel/pull/5328#issuecomment-1705890992

   > > AbstractCreateTableSqlBuilder
   > 
   > The four classes, namely MysqlCreateTableSqlBuilder, OracleCreateTableSqlBuilder, PostgresCreateTableSqlBuilder, and SqlServerCreateTableSqlBuilder, share some commonality only between OracleCreateTableSqlBuilder and PostgresCreateTableSqlBuilder. For the rest, aside from class attributes that can be extracted into an abstract class, there doesn't appear to be much commonality to extract since each database requires its own unique table creation SQL construction and they differ significantly. Would it still be necessary to create an abstract class called AbstractCreateTableSqlBuilder for this situation?
   
   I see, we can do it later after we have catalog module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org