You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ivan Daschinsky (Jira)" <ji...@apache.org> on 2022/11/24 19:42:00 UTC

[jira] [Commented] (IGNITE-17599) Calcite engine. Support LocalDate/LocalTime types

    [ https://issues.apache.org/jira/browse/IGNITE-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638405#comment-17638405 ] 

Ivan Daschinsky commented on IGNITE-17599:
------------------------------------------

[~alex_pl] Could you please review this patch?

> Calcite engine. Support LocalDate/LocalTime types
> -------------------------------------------------
>
>                 Key: IGNITE-17599
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17599
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.14
>            Reporter: Aleksey Plekhanov
>            Assignee: Ivan Daschinsky
>            Priority: Major
>              Labels: calcite2-required, calcite3-required, ise
>             Fix For: 2.15
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> H2-based engine works with LocalData/LocalTime types as java.sql.Data/java.sql.Time types. To check if value with LocalDate type can be inserted to descriptor with type java.sql.Data some logic from \{{IgniteH2Indexing.isConvertibleToColumnType}} is used. If Calcite engine used without ignite-indexing this logic is unavailable.
> We should:
>  # Provide an ability to work in Calcite-based engine with LocalDate/LocalTime type in the same way as java.sql.Data/java.sql.Time types.
>  # Move \{{IgniteH2Indexing.isConvertibleToColumnType}} logic to the core module (perhaps delegating this call from the core to the QueryEngine instance)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)